This repository was archived by the owner on Apr 2, 2024. It is now read-only.
Log warning when remote read request is cancelled midway #1180
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antekresic
force-pushed
the
fix-annoying-log
branch
from
df45335 to
7b49f1d
Compare
sumerman
reviewed
Feb 22, 2022
Previously, we were trying to update the header but that cannot be done in this instance since we are already starting to write the request body. Only valid way of handling these situations is to log the error and finish the request.
antekresic
force-pushed
the
fix-annoying-log
branch
from
7b49f1d to
610a5e6
Compare
Harkishen-Singh
approved these changes
Feb 22, 2022
sumerman
approved these changes
Feb 22, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Previously, we were trying to update the header but that cannot be
done in this instance since we are already starting to write the
request body. Only valid way of handling these situations is to
log the error and finish the request.
Merge requirements
Please take into account the following non-code changes that you may need to make with your PR: