This repository was archived by the owner on Apr 2, 2024. It is now read-only.
deploy/helm: fix order of templating #1126
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tested this locally by changing And running After we migrate helm charts I will be adding such tests to CI |
paulfantom
requested review from
cevian,
VineethReddy02 and
JamesGuthrie
as code owners
paulfantom
force-pushed
the
paulfantom-patch-1
branch
from
ea18a9f to
51796a2
Compare
JamesGuthrie
approved these changes
Feb 10, 2022
cevian
approved these changes
Feb 10, 2022
auto-merge was automatically disabled
February 14, 2022 09:19
Rebase failed
To use `tpl` function, content needs to be first unpacked/serialized with `toYaml` and not the other way round. Signed-off-by: Paweł Krupa (paulfantom) <[email protected]>
paulfantom
force-pushed
the
paulfantom-patch-1
branch
from
14115e8 to
259e483
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To use
tplfunction, content needs to be first unpacked/serialized withtoYamland not the other way round.Description
Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be sure to link to that issue.
Sorry for brevity of doing this edit via GUI (hence branch is not in my fork) :)
Merge requirements
Please take into account the following non-code changes that you may need to make with your PR: