This repository was archived by the owner on Apr 2, 2024. It is now read-only.
Add Prometheus metrics support for Tracing #1102
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Harkishen-Singh
force-pushed
the
instrument-metrics-for-tracing-path
branch
4 times, most recently
from
f951884 to
bd1da26
Compare
Harkishen-Singh
requested review from
cevian,
antekresic and
paulfantom
and removed request for
cevian and
antekresic
Harkishen-Singh
requested review from
niksajakovljevic and
a team
as code owners
Harkishen-Singh
force-pushed
the
instrument-metrics-for-tracing-path
branch
3 times, most recently
from
aa707cf to
f9034e7
Compare
Harkishen-Singh
force-pushed
the
instrument-metrics-for-tracing-path
branch
from
a809013 to
4cbdf4c
Compare
Signed-off-by: Harkishen-Singh <[email protected]> This commit implements Prometheus metrics for tracing module that includes: 1. Ingest 2. Query 3. Cache This commit also puts all shared metrics into pgmodel/metrics so that ingestor and querier can easily access them and utilize their labels for 'type'.
Signed-off-by: Harkishen-Singh <[email protected]> In the previous commit, we added a common metric promscale_query_duration_seconds{handler, type} to track duration of all query based executions across all functions (and APIs when we implement for metrics) hence the previous promscale_trace_fetch_traces_api_execution_duration_seconds_bucket now becomes trivial. This commit removes it and replaces it with the new convention so that telemetry collection does not get affected with this update.
Harkishen-Singh
force-pushed
the
instrument-metrics-for-tracing-path
branch
from
4cbdf4c to
44bf80a
Compare
Harkishen-Singh
changed the title
Harkishen-Singh
force-pushed
the
instrument-metrics-for-tracing-path
branch
from
44bf80a to
5ee0244
Compare
antekresic
approved these changes
Feb 4, 2022
antekresic
suggested changes
Feb 4, 2022
Harkishen-Singh
force-pushed
the
instrument-metrics-for-tracing-path
branch
from
886c4af to
13738b2
Compare
Harkishen-Singh
force-pushed
the
instrument-metrics-for-tracing-path
branch
from
13738b2 to
548f7f5
Compare
antekresic
approved these changes
Feb 4, 2022
paulfantom
reviewed
Feb 7, 2022
paulfantom
reviewed
Feb 7, 2022
Harkishen-Singh
force-pushed
the
instrument-metrics-for-tracing-path
branch
from
548f7f5 to
0261f72
Compare
paulfantom
reviewed
Feb 8, 2022
Harkishen-Singh
force-pushed
the
instrument-metrics-for-tracing-path
branch
from
0261f72 to
3330793
Compare
Signed-off-by: Harkishen-Singh <[email protected]> As per the design doc, now type can have ['metric', 'trace']. This commit ensures the same, leaving subsystem for ['metric_batcher', 'copier'] which will be implemented in another PR that will be responsible to update all metric path based metrics.
Harkishen-Singh
force-pushed
the
instrument-metrics-for-tracing-path
branch
from
3330793 to
a95c683
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be sure to link to that issue.
Merge requirements
Please take into account the following non-code changes that you may need to make with your PR: