This repository was archived by the owner on Apr 2, 2024. It is now read-only.
Optimize insert path in the DB by avoiding ON CONFLICT #1090
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cevian
force-pushed
the
on_conflict_opt
branch
2 times, most recently
from
c972b50 to
69bd1bf
Compare
jgpruitt
approved these changes
Jan 27, 2022
antekresic
approved these changes
Jan 28, 2022
Turns out there is a horrible CPU perf penalty on the DB for ON CONFLICT DO NOTHING. yet in our data, conflicts are rare. So we first try inserting without ON CONFLICT and fall back if there is a unique constraint violation. Unlike retriying with COPY this does not require sending the data again and thus saves latency and bandwidth.
cevian
force-pushed
the
on_conflict_opt
branch
from
69bd1bf to
c6ccd13
Compare
|
@antekresic we have some work in https://github.com/cevian/postbench but yeah adding to go benchmarks will also be good |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Turns out there is a horrible CPU perf penalty on the DB for ON CONFLICT DO NOTHING.
yet in our data, conflicts are rare. So we first try inserting without ON CONFLICT
and fall back if there is a unique constraint violation.
Unlike retriying with COPY this does not require sending the data again
and thus saves latency and bandwidth.
Description
Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be sure to link to that issue.
Merge requirements
Please take into account the following non-code changes that you may need to make with your PR: