This repository was archived by the owner on Apr 2, 2024. It is now read-only.
Fix skipping compression of first to last chunk #1081
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antekresic
requested review from
VineethReddy02
and removed request for
a team
antekresic
force-pushed
the
fix-compress-old-chunks
branch
3 times, most recently
from
583cb1f to
b909a82
Compare
antekresic
changed the title
antekresic
changed the title
antekresic
requested review from
cevian
and removed request for
VineethReddy02
JamesGuthrie
suggested changes
Jan 26, 2022
jgpruitt
approved these changes
Jan 26, 2022
antekresic
force-pushed
the
fix-compress-old-chunks
branch
2 times, most recently
from
771d85e to
add0db3
Compare
Due to a bug in logic, we were skipping compression of the first to last chunk which ended over an hour ago from current time. This was causing to have one more chunk per metric uncompressed, causing us to use more storage than necessary.
antekresic
force-pushed
the
fix-compress-old-chunks
branch
from
add0db3 to
9a70e0c
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Due to a bug in logic, we were skipping compression of the first
to last chunk which ended over an hour ago from current time. This was
causing to have one more chunk per metric uncompressed, causing
us to use more storage than necessary.
Merge requirements
Please take into account the following non-code changes that you may need to make with your PR:
Updated the relevant documentation