Skip to content
This repository was archived by the owner on Apr 2, 2024. It is now read-only.

Conversation

harkishen
Copy link
Member

@harkishen harkishen commented Jan 25, 2022

Signed-off-by: Harkishen-Singh [email protected]

This commits fixes the promscale_packager telemetry field that was
earlier showing unknown for all docker deployments. Now, it will show
promscale_packager: docker in the _timescaledb_catalog.metadata
table.

Metadata table output

 promscale_packager                                          | docker                               | t
 promscale_os_node_name                                      | 2bce24e46fcc                         | t

Description

Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be sure to link to that issue.

Merge requirements

Please take into account the following non-code changes that you may need to make with your PR:

  • CHANGELOG entry for user-facing changes
  • Updated the relevant documentation

@harkishen harkishen self-assigned this Jan 25, 2022
@harkishen harkishen requested a review from a team as a code owner January 25, 2022 09:36
@harkishen harkishen force-pushed the fix-telemetry-docker branch from 718ed04 to c513ccb Compare January 25, 2022 09:36
Signed-off-by: Harkishen-Singh <[email protected]>

This commits fixes the `promscale_packager` telemetry field that was
earlier showing `unknown` for all docker deployments. Now, it will show
`promscale_packager: docker` in the `_timescaledb_catalog.metadata`
table.
@harkishen harkishen force-pushed the fix-telemetry-docker branch from c513ccb to 48e7487 Compare January 25, 2022 09:46
Copy link
Member

@antekresic antekresic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should check the value from env variable before sending it to telemetry because telemetry will be stored long-term by us.

@harkishen harkishen merged commit c6d6feb into timescale:master Jan 25, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants