Skip to content

Conversation

AirSkye
Copy link
Contributor

@AirSkye AirSkye commented Apr 26, 2025

原因是在 render_then_merge 函数里,调用 get_resolution 函数获取视频的分辨率时,返回值是一个包含 resolution_x 和 resolution_y 的元组。而在调用 process_danmakus 函数时,只传入了 xml_path 和 video_resolution,process_danmakus 函数需要分别传入 resolution_x 和 resolution_y 这两个参数。

# render_then_merge.py
video_resolution = get_resolution(original_video_path)
subtitle_font_size, subtitle_margin_v = process_danmakus(
    xml_path, video_resolution
)

修复merge模式下报错问题
Copy link
Owner

@timerring timerring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@timerring timerring self-assigned this Apr 26, 2025
@timerring timerring merged commit 41dc02e into timerring:main Apr 26, 2025
@timerring timerring linked an issue Apr 26, 2025 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] macos arm64 docker下使用merge模式只录制,上传失败
2 participants