Skip to content
This repository was archived by the owner on Jun 13, 2025. It is now read-only.

Conversation

grddavies
Copy link
Contributor

fixes: #979

Slice was failing on any slice pN of 1. This was because the begin of the next slice was being used to calculate the end of the first. With slice 1 _ all slices begin at 0.0, so end is incorrectly set to 0.0.

This implementation calculates the end control pattern by generating a sample-width pattern, and adding this to the begin pattern.

Two tests are added:

  • slice "can slice samples" - Regression test that passes on dev and this branch
  • slice "can slice by 1" - Test for accurate calculation of sample end time when slicing into 1

@yaxu yaxu merged commit c69162e into tidalcycles:dev Jun 9, 2024
@yaxu
Copy link
Member

yaxu commented Jun 9, 2024

Thanks!

@yaxu yaxu mentioned this pull request Jan 14, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

slice of 1 doesn't work
2 participants