-
Notifications
You must be signed in to change notification settings - Fork 54
Format output xml and align GUID format for fpdt_parser #1006
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Format output xml and align GUID format for fpdt_parser #1006
Conversation
|
@makubacki can you take a look at this? It looks fine to me, but I'm unsure. Marking this as a breaking change as it changes the returned data. |
Javagedes
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
At a minimum, it looks like you need to run the ruff formatter to be compliant with the CI
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is quite the breaking change. Can you please add additional description to this PR regarding that?
Specifically, I think the breaking changes are:
- The Guid format changing
- The overall format of the xml appears to be changing:
|- fbpt_header
|- fbpt_record
|- fbpt_record
to
|- fbpt_header
| |- fbpt_record
| |- fbpt_record
Specifically, please provide examples of the changes, and integration instructions for anyone that uses this tool.
You also need to run the ruff formatter to be compliant with CI :)
|
@liqiqiii, the changes look fine, I'll approve after Joey's comments are addressed. |
Hi Joey, I have updated the PR description. |
|
@liqiqiii bump for this PR so we can get CI working and this merged in |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1006 +/- ##
==========================================
+ Coverage 78.75% 79.46% +0.71%
==========================================
Files 49 44 -5
Lines 4909 6273 +1364
==========================================
+ Hits 3866 4985 +1119
- Misses 1043 1288 +245
🚀 New features to boost your workflow:
|
Format output xml and align GUID format for fpdt_parser.
Apply
minidomto format the output xml of thefpdt_parser.pyto improve readability.The script was not adding entries to FBDT table so the output is not a proper tree structure.
Before it was:
Now it is:
it can be properly consumed by
perf_report_generator.pyto generate perf report. Before this change there will be 0 entries in the report because the input structure doesn't match what the script needs.Update the GUID format for different entries to make sure the output GUID format stay the same and can be recognized by the perf_report_generator.py.
Add xml formatter to make sure the output xml more readable.
Examples for GUID format change:
With this change the
perf_report_generator.pycan successfully parse these GUIDs and map to the right module name.Breaking change?
Detail of the changes can be seen above. The structure and content of the output xml for
fpdt_parser.pychanged.Integration instruction:
Use
fpdt_parser.pyfirst and use the output xml file as the input for theperf_report_generator.pyto get perf report.