Skip to content

Remove FLAGS Argument from target_check_warning Function #36

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 17, 2023
Merged

Remove FLAGS Argument from target_check_warning Function #36

merged 2 commits into from
Dec 17, 2023

Conversation

threeal
Copy link
Owner

@threeal threeal commented Dec 17, 2023

This pull request removes the FLAGS argument from the target_check_warning function in favor of calling target_compile_options function to specify additional flags. It closes #34.

@threeal threeal self-assigned this Dec 17, 2023
@threeal threeal added the feat label Dec 17, 2023
@threeal threeal added this to the Version 1.2.0 milestone Dec 17, 2023
@threeal threeal marked this pull request as ready for review December 17, 2023 15:35
@threeal threeal merged commit 6be590d into main Dec 17, 2023
@threeal threeal deleted the target-check-warning-rm-flags branch December 17, 2023 15:35
@threeal threeal modified the milestones: Version 1.2.0, Version 1.3.0 Dec 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@threeal threeal

Labels

feat

Projects

None yet

Milestone

Version 2.0.0

Development

Successfully merging this pull request may close these issues.

Remove FLAGS Argument from target_check_warning Function

1 participant

@threeal