Fix webxrmanager #7
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 8 commits
February 8, 2021 18:15
getReferenceSpace / getSession should be nullable
setSession should return Promise<void> instead of void since r125 See: mrdoob/three.js#20754
Trivial rename of arguments
webxr-vr-cube.ts, a simple example featuring WebXR VR
XRSession should extend EventTarget
Forgot to add `webxr-vr-cube.ts` to the tsconfig.json
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original PR I've made: DefinitelyTyped/DefinitelyTyped#51033
Why
The primary motivation is to follow changes made in mrdoob/three.js#20754.
What
webxr-vr-cube.ts.Checklist