ShaderNodeFn: improve DX for Layout #1493
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| inputs: { name: string; type: string }[]; | ||
| inputs: { | ||
| name: string; | ||
| type: "bool" | "int" | "float" | "vec2" | "vec3" | "vec4"; |
There was a problem hiding this comment.
Aren't there more possible types than this?
There was a problem hiding this comment.
Aren't there more possible types than this?
I don't remember why I wrote that...
Maybe use the type in the NodeUtils.js -> getValueFromType method, which should be more complete
type: "bool" | "int" | "uint" | "float" | "vec2" | "vec3" | "vec4" | "mat2" | "mat3" | "mat4" | "color" | "string" | "ArrayBuffer";There was a problem hiding this comment.
I'm just going to change it back to string for now until I have time to look into it some more.
Methuselah96
approved these changes
Jan 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As the title says.