- 
          
 - 
                Notifications
    
You must be signed in to change notification settings  - Fork 183
 
Update IFCLoader types #104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| 
           Have you ran prettier? I might add it as a husky hook to slim down this happens, I can appreciate its a bit annoying.  | 
    
| 
           Sorry, I missed it. I'll run it! A husky hook would be nice for the future :)  | 
    
| 
           Hum, strange. I ran prettier with Webstorm (control alt L) and   | 
    
| 
           It's failing on lint errors now:  | 
    
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Is this for the current release or the upcoming new release?
          
 For the next release 🙂 mrdoob/three.js#22352 (comment)  | 
    
We have added lots of new functionalities to the new version of the IFC Loader (which is already merged), and we just updated the types.