Skip to content

fix: update script failure on Apple Silicon (arm64) #506

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

tanmay-pnaik
Copy link

Description

This PR fixes the automatic update script failure on Apple Silicon Macs (M1, M2, M3, etc.) reported in issue #363.

Root Cause

The update_talisman.bash script had two issues:

  1. Missing variable declaration: The script used $E_UNSUPPORTED_ARCH but never defined it, causing an 'unbound variable' error
  2. Incorrect error message: The error message stated only x86 and x86_64 were supported, even though arm64 logic was already implemented

Changes Made

  • ✅ Added missing E_UNSUPPORTED_ARCH=5 variable declaration (consistent with other scripts)
  • ✅ Updated error message to accurately reflect arm64 support: "x86, x86_64 and arm64 architectures"

Verification

  • ✅ Script passes bash syntax validation
  • ✅ No linter errors
  • ✅ arm64 architecture detection logic already exists and works correctly
  • ✅ Aligns with existing install.bash and install.sh scripts that already support Apple Silicon

Expected Impact

Apple Silicon users will no longer encounter:

Talisman currently only supports x86 and x86_64 architectures.
/tmp/update_talisman.bash: line 97: E_UNSUPPORTED_ARCH: unbound variable

The script will now properly:

  • Detect arm64 architecture
  • Generate correct binary name (talisman_darwin_arm64)
  • Complete updates successfully on Apple Silicon Macs

Fixes #363

@tanmay-pnaik tanmay-pnaik force-pushed the fix/update-script-arm64-support branch from 23ca131 to e75f395 Compare August 9, 2025 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Automatic update script fails on an Apple M1 Mac (arm64)
1 participant