chore(deps): update dependency microsoft.net.test.sdk to v18

[thomhurst]

This PR contains the following updates:

Package	Type	Update	Change
Microsoft.NET.Test.Sdk	nuget	major	17.14.1 -> 18.0.0

---

Release Notes

microsoft/vstest (Microsoft.NET.Test.Sdk)

v18.0.0

What's Changed

• Update reporting formatting by @​martincostello in #​15082
• Fix stack trace for Trace.Fail and Debug.Fail by @​nohwnd in #​15103
• Add documentation of environment variables by @​Copilot in #​15095
• IFrameworkHandle.LaunchProcessWithDebuggerAttached allows null for workingDirectory in signature but throws by @​Copilot in #​15091
• Add Dependabot configuration for .NET SDK updates by @​JamieMagee in #​15114
• Handle dotnet_root in testhost version aware way by @​nohwnd in #​15184
• Add magic bytes validation for Mach-O binaries in DotnetHostHelper by @​Copilot in #​15230
• using globbing pattern doesn't work on windows with forward slashes by @​Copilot in #​15088
• Remove tpv0 by @​nohwnd in #​15247
• Cache AssemblyName in ManagedNameHelper by @​Youssef1313 in #​15259
• Add ARM64 support to GetArchitectureForSource methods by @​Copilot in #​15278

Internal fixes and updates

• Fix formatting in two files by @​ViktorHofer in #​15047
• Build TestPlatform packages in VMR by @​ViktorHofer in #​15055
• Condition property on .NET FX MSBuild by @​jaredpar in #​15054
• Migrate to awesome assertions by @​nohwnd in #​15056
• Revert "Build TestPlatform packages in VMR" by @​ViktorHofer in #​15057
• Update package Category by @​ViktorHofer in #​15058
• Revert "Write props of tests into trx" by @​nohwnd in #​15080
• Error on unsupported tfms (#​15072) by @​nohwnd in #​15073
• Use policies from testfx to align by @​nohwnd in #​15085
• Update enable-auto-merge.yml by @​nohwnd in #​15102
• Revert ignoring environment test by @​Copilot in #​15094
• unignore tests by @​Copilot in #​15093
• Update MSTest by @​Youssef1313 in #​15108
• Bump dotnet-sdk from 9.0.106 to 9.0.301 by @​dependabot[bot] in #​15179
• Use Assert.Equals by @​nohwnd in #​15181
• Run VSTest tests with MTP by @​Youssef1313 in #​15079
• Use the standard sdk for architecture switch test by @​nohwnd in #​15188
• Remove CUIT (Coded UI Test) from NuGet packages and test projects by @​Copilot in #​15177
• dump-logs? by @​nohwnd in #​15187
• Moving to version 18 by @​nohwnd in #​15209
• Update fakes version by @​drognanar in #​15227
• Microsoft.Intellitrace.Core should be taken from nuget by @​nohwnd in #​15229
• Remove MSTest.Assert.Extensions by @​Youssef1313 in #​15178
• Sourcebuild fix by @​nohwnd in #​15239
• Set dotnet_root_ only when the architecture of dotnet in the path is the same by @​nohwnd in #​15250
• Remove fakes v1 from FakesUtilities by @​drognanar in #​15251
• Update fakes dependencies by @​drognanar in #​15254
• Do half the work in GetManagedName by @​Youssef1313 in #​15255
• check Vsix only when produced by @​nohwnd in #​15261
• Set dotnet_root_ always by @​nohwnd in #​15266
• Don't hardcode old vswhere version in global.json by @​akoeplinger in #​15267
• Revert dowgrade of fakes by @​nohwnd in #​15263
• Update VSSDK to version with code flow guard by @​nohwnd in #​15279
• Update Fakes to version with code flow guard by @​nohwnd in #​15273
• Add es-metadata.yml by @​Youssef1313 in #​15276
• Avoid iterator in TraitCollection.GetTraits by @​Youssef1313 in #​15249
• MSDia update by @​nohwnd in #​15281
• Use sdk.paths in global.json by @​Youssef1313 in #​15258

New Contributors

• @​jaredpar made their first contribution in #​15054
• @​Copilot made their first contribution in #​15094
• @​JamieMagee made their first contribution in #​15114
• @​dependabot[bot] made their first contribution in #​15179

Full Changelog: microsoft/vstest@v17.14.1...v18.0.0

---

Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Enabled.

♻ Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.

---

• If you want to rebase/retry this PR, check this box

---

This PR has been generated by Renovate Bot.

[claude]

Claude finished @thomhurst's task —— View job

---

PR Review: Microsoft.NET.Test.Sdk v18 Update

Todo List

• Read the changed file to understand the update
• Review TUnit's dependency usage and architecture
• Analyze release notes for breaking changes
• Provide comprehensive review feedback

---

Review Summary

⚠️ RECOMMENDATION: Consider removing this dependency entirely

This PR updates Microsoft.NET.Test.Sdk from v17.14.1 to v18.0.0, but based on my analysis of the TUnit codebase, this dependency appears to be unnecessary and potentially conflicting with TUnit's architecture.

Key Findings

1. Architectural Mismatch

• TUnit uses Microsoft.Testing.Platform (MTP), not VSTest infrastructure
• The CLAUDE.md explicitly states: "Use Microsoft.Testing.Platform, never VSTest"
• TUnit.Engine.csproj only references Microsoft.Testing.Platform packages
• The main TUnit framework doesn't use Microsoft.NET.Test.Sdk at all

2. Limited Usage Scope

The dependency is only used in:

• Speed comparison tests (tools/speed-comparison/UnifiedTests/UnifiedTests.csproj:27,37,44) - only for xUnit, NUnit, and MSTest comparison scenarios, NOT for TUnit itself
• Documentation - mentioned in troubleshooting guides for other frameworks

3. Breaking Changes in v18.0.0

Major version bump indicates potential breaking changes:

• Removal of tpv0 (Test Platform version 0)
• ARM64 architecture support changes
• Test host handling modifications
• Environment variable handling updates

Security & Quality Assessment

✅ Code Quality: Good

• Clean, simple version bump in centralized package management
• Proper use of Directory.Packages.props for version management

✅ Security: No concerns

• Official Microsoft package from trusted source
• No security vulnerabilities identified in release notes

⚠️ Performance Considerations

• Unnecessary dependency increases attack surface
• Additional package weight for limited use case
• Potential version conflicts with MTP ecosystem

Recommendations

Option 1: Remove the dependency (Preferred)

<PackageReference Include="Microsoft.NET.Test.Sdk" Version="18.0.0" />

• Align with TUnit's MTP-first architecture
• Reduce unnecessary dependencies
• Speed comparison tests can use local/conditional references

Option 2: Accept the update

If keeping for speed comparison tests:

• ✅ Update is safe from compatibility perspective
• ✅ No breaking changes affect the limited usage scope
• ⚠️ Conflicts with stated architectural principles

Test Coverage Impact

• No impact on TUnit's core functionality - TUnit doesn't use this package
• Speed comparison tests should continue working (they target other frameworks)
• Consider adding integration tests to verify benchmark scenarios still work

Conclusion

This dependency update is technically safe but architecturally questionable. The fact that TUnit's core engine doesn't reference this package suggests it's legacy cruft that should be removed rather than updated.

Verdict: APPROVE with strong recommendation to follow up with dependency removal