feature: Added ExcludeOnAttribute and RunOnAttribute
#2512
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samtrion
force-pushed
the
feature/runonattribute-excludeonattribute
branch
from
0f0e95f to
788d2f6
Compare
thomhurst
reviewed
Jun 3, 2025
thomhurst
reviewed
Jun 3, 2025
samtrion
force-pushed
the
feature/runonattribute-excludeonattribute
branch
from
4ab733a to
6aea138
Compare
|
@thomhurst I'm ready for review. This implementation should be as simple as possible, I think. |
|
Thanks @samtrion ! You'll need to run the public API tests and update the snapshots |
|
Irks, missed the public api tests again |
Done |
|
Thanks! |
This was referenced Jul 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #2508
Please give me some feedback, before I start creating tests for these attributes