Skip to content

remove namespace and append guid to AssemblyLoader #2269

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Apr 18, 2025
Merged

remove namespace and append guid to AssemblyLoader #2269

merged 7 commits into from
Apr 18, 2025

Conversation

SimonCropp
Copy link
Contributor

fixes #2268

@thomhurst
Copy link
Owner

Your own verify tests are failing you 😛

@SimonCropp
Copy link
Contributor Author

lol. yeah i will get to it today

@SimonCropp
Copy link
Contributor Author

@thomhurst can u approve the CI

@thomhurst thomhurst enabled auto-merge (squash) April 18, 2025 02:35
@SimonCropp
Copy link
Contributor Author

SimonCropp commented Apr 18, 2025 •
edited
Loading

weird. on my machine i get a

global::TUnit.Core.SourceRegistrar.RegisterAssembly(() => typeof(global::System.Xml.Linq.XAttribute).Assembly);

do u want me to manually fix it? or would you like my help debugging as to why?

auto-merge was automatically disabled April 18, 2025 07:00

Head branch was pushed to by a user without write access

@thomhurst thomhurst enabled auto-merge (squash) April 18, 2025 08:53
@thomhurst
Copy link
Owner

Thanks for this @SimonCropp !

@thomhurst thomhurst merged commit 695dd85 into thomhurst:main Apr 18, 2025
9 checks passed
@SimonCropp SimonCropp deleted the remove-namespace-and-append-guid-to-AssemblyLoader branch April 18, 2025 10:48
@SimonCropp
Copy link
Contributor Author

@thomhurst no worries :)

@SimonCropp
Copy link
Contributor Author

i updated and tested on Verify. and can confirm the problem is fixed. Go Team!

@dependabot dependabot bot mentioned this pull request Jul 23, 2025
Closed
@dependabot dependabot bot mentioned this pull request Jul 30, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

V 0.19.82 breaks Verify
2 participants
@SimonCropp @thomhurst