[Bug]: Assigning popup parameter initial_style may not apply

[cadavre]

My Home Assistant Version

Browser Mod: 2.6.3

I've noticed there probably something really wrong with assigning new popup parameters. I noticed this when tried to have just a single style for all my popups.

Case 1:

1. Open:

  "dismissable": true,
  "initial_style": "classic",
  "tag": "camera",
  "content": { // Card #1

Narrow popup opens.

2. Open:

{
  "dismissable": true,
  "initial_style": "wide",
  "tag": "camera",
  "content": { // Card #2

Wide popup opens.

3. Open:

  "dismissable": true,
  "initial_style": "classic",
  "tag": "camera",
  "content": { // Card #1

Popup opens that is again: wide.

Only if I close "initial_style": "wide" with browser_mod.close_popup I'm able to re-open narrow popup again.

I also noticed that other parameters are often mixed up, like autoclose or dismissable being (de)activated when they shouldn't.

This looks like some browser-side object storing options is not garbage-collected well.

What I am doing

Opening popups with different sizes.

What I expect to happen

Opened popups are having different sizes.

What happened instead

Opened popups are having same sizes.

Minimal steps to reproduce

1. Open popup w/ "initial_style": "classic" – narrow opens.
2. Open popup w/ "initial_style": "wide" – wide opens.
3. Open popup w/ "initial_style": "classic" – wide opens.
4. Open popup w/ "initial_style": "wide" – wide opens.
5. Close popup via service.
6. Open popup w/ "initial_style": "classic" – narrow opens.

Include any yaml code here

Error messages from the browser console

n/a

By checking each box below I indicate that I ...

• Understand that this is a channel for reporting bugs, not a support forum (https://community.home-assistant.io/).
• Have made sure I am using the latest version of the plugin.
• Understand that leaving one or more boxes unticked or failure to follow the template above may increase the time required to handle my bug-report, or cause it to be closed without further action.
• If this issue is to do with an Android device losing connection, sensors becoming unavailable etc., please confirm you have read, understood and tried methods described in Wiki Article Andoird Devices 'Always On'

[cadavre]

Reverted back to latest Browser Mod: 2.5 and it works as expected.

[dcapslock]

@cadavre I have replicated the initial_style issue which will be fixed by PR #1076.

As for there being a wider spread issue to correct, I don't believe there is. The initial_style issue was due to clearing the array that keeps track of which styles have been applied to make sure they are set/remove from the popup element. In the case you outlined, the issue meant both "normal" and "wide" attributes were incorrectly set on the popup, as wide was no longer being tracked after being cleared from the tacking array. This has now been corrected. As for dismissable and autoClose, they are correctly set on each popup setup, taking their defaults if not defined (dismissable = true, auto_close = false).

If you can provide any further config examples with issues, please submit a new issue so these can be tracked and fixed indepedently. Thank you.

[dcapslock]

v2.6.4-beta.1 available for testing which incudes the fix for initial_style when repoening a popup with the same tag.

[dcapslock]

@cadavre any chance to review the beta? Thanks

[dcapslock]

@cadavre looking to release 2.6.4 but waiting on your feedback. Thank you.

[cadavre]

@dcapslock sorry, I got busy by personal matters. I'll check today evening, thanks!

[dcapslock]

@cadavre did you get a chance to check? Thank you

[cadavre]

Confirmed! It's fixed in latest beta.