-
Notifications
You must be signed in to change notification settings - Fork 4
ISS-55 #835
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ISS-55 #835
Conversation
Signed-off-by: Bruno Kucevic <[email protected]>
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Signed-off-by: Bruno Kucevic <[email protected]>
Signed-off-by: Bruno Kucevic <[email protected]>
Signed-off-by: Bruno Kucevic <[email protected]>
Signed-off-by: Bruno Kucevic <[email protected]>
Signed-off-by: Bruno Kucevic <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds a comprehensive skeleton loading system throughout the application, replacing existing loading components with specific skeleton implementations and enhancing the data table component to display skeleton rows during loading states.
- Implements skeleton components for various UI patterns (titles, buttons, labels, tables, etc.)
- Enhances DataTable component to show skeleton rows during loading
- Replaces generic loading components with contextual skeleton loading screens
Reviewed Changes
Copilot reviewed 45 out of 46 changed files in this pull request and generated 4 comments.
Show a summary per file
File | Description |
---|---|
packages/ui/src/data-table/data-table.tsx | Enhanced NoData component to show skeleton rows during loading |
apps/console/src/components/shared/skeleton/*.tsx | New skeleton components for different UI elements |
apps/console/src/app/(protected)/*/loading.tsx | Updated loading pages to use specific skeleton components |
apps/console/src/components/pages/protected//skeleton/.tsx | Page-specific skeleton components |
Various component files | Updated to use new loading prop and skeleton components |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
skeletons initial