Skip to content

Conversation

BrunoKucevic
Copy link
Contributor

skeletons initial

Signed-off-by: Bruno Kucevic <[email protected]>
Copy link

vercel bot commented Aug 18, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
openlane-ui Ready Ready Preview Comment Aug 25, 2025 11:00pm
storybook Ready Ready Preview Comment Aug 25, 2025 11:00pm

Signed-off-by: Bruno Kucevic <[email protected]>
Signed-off-by: Bruno Kucevic <[email protected]>
Signed-off-by: Bruno Kucevic <[email protected]>
Signed-off-by: Bruno Kucevic <[email protected]>
@golanglemonade golanglemonade requested a review from Copilot August 25, 2025 15:07
@golanglemonade golanglemonade requested review from Copilot and removed request for Copilot August 25, 2025 15:17
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds a comprehensive skeleton loading system throughout the application, replacing existing loading components with specific skeleton implementations and enhancing the data table component to display skeleton rows during loading states.

  • Implements skeleton components for various UI patterns (titles, buttons, labels, tables, etc.)
  • Enhances DataTable component to show skeleton rows during loading
  • Replaces generic loading components with contextual skeleton loading screens

Reviewed Changes

Copilot reviewed 45 out of 46 changed files in this pull request and generated 4 comments.

Show a summary per file
File Description
packages/ui/src/data-table/data-table.tsx Enhanced NoData component to show skeleton rows during loading
apps/console/src/components/shared/skeleton/*.tsx New skeleton components for different UI elements
apps/console/src/app/(protected)/*/loading.tsx Updated loading pages to use specific skeleton components
apps/console/src/components/pages/protected//skeleton/.tsx Page-specific skeleton components
Various component files Updated to use new loading prop and skeleton components

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@golanglemonade golanglemonade merged commit 8e41c5b into main Aug 26, 2025
7 checks passed
@golanglemonade golanglemonade deleted the ISS-55 branch August 26, 2025 05:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants