Skip to content

Conversation

@jafiala
Copy link
Contributor

@jafiala jafiala commented Oct 23, 2025

What changes are you introducing?

Add sendmail deprecation

Why are you introducing these changes? (Explanation, links to references, issues, etc.)

Sendmail is deprecated in Satellite 6.18 and will be removed in a future release.

Anything else to add? (Considerations, potential downsides, alternative solutions you have explored, etc.)

Contributor checklists

  • I am okay with my commits getting squashed when you merge this PR.
  • I am familiar with the contributing guidelines.

Please cherry-pick my commits into:

  • Foreman 3.16/Katello 4.18 (Satellite 6.18)
  • Foreman 3.15/Katello 4.17
  • Foreman 3.14/Katello 4.16 (Satellite 6.17; orcharhino 7.4)
  • Foreman 3.13/Katello 4.15 (EL9 only)
  • Foreman 3.12/Katello 4.14 (Satellite 6.16; orcharhino 7.2 on EL9 only; orcharhino 7.3)
  • Foreman 3.11/Katello 4.13 (orcharhino 6.11 on EL8 only; orcharhino 7.0 on EL8+EL9; orcharhino 7.1 with Leapp)
  • Foreman 3.10/Katello 4.12
  • Foreman 3.9/Katello 4.11 (Satellite 6.15; orcharhino 6.8/6.9/6.10)
  • We do not accept PRs for Foreman older than 3.9.

@jafiala jafiala requested a review from Lennonka October 23, 2025 09:43
@github-actions github-actions bot added Needs tech review Requires a review from the technical perspective Needs style review Requires a review from docs style/grammar perspective Needs testing Requires functional testing labels Oct 23, 2025
@github-actions
Copy link

Copy link
Contributor

@maximiliankolb maximiliankolb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

two small suggestions. I think an explicit tech ACK would be good too.

Comment on lines +44 to +45
=== Preparing {Project} for operation in containerized environments
- *`sendmail` is deprecated for delivering email* - Delivering email by calling the `sendmail` binary on the system is problematic in many cases.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
=== Preparing {Project} for operation in containerized environments
- *`sendmail` is deprecated for delivering email* - Delivering email by calling the `sendmail` binary on the system is problematic in many cases.
=== Preparing {Project} for operation in containerized environments
* *`sendmail` is deprecated for delivering email* - Delivering email by calling the `sendmail` binary on the system is problematic in many cases.

suggestion: We generally use a single empty line between headings and paragraphs; and * for unordered lists.

- *`sendmail` is deprecated for delivering email* - Delivering email by calling the `sendmail` binary on the system is problematic in many cases.
Therefore, it is deprecated and will be removed in a future version.
As an alternative, use the SMTP mail delivery method.
For more information, see link:https://docs.theforeman.org/3.16/Installing_Server/index-katello.html#Configuring_Server_for_Outgoing_Emails_foreman[Configuring Foreman server for outgoing emails].
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
For more information, see link:https://docs.theforeman.org/3.16/Installing_Server/index-katello.html#Configuring_Server_for_Outgoing_Emails_foreman[Configuring Foreman server for outgoing emails].
For more information, see {InstallingServerDocURL}Configuring_Server_for_Outgoing_Emails_foreman[Configuring {ProjectServer} for outgoing emails].

That way, the URL for foreman will point to Foreman; for katello to foreman+Katello.

@maximiliankolb maximiliankolb removed the Needs testing Requires functional testing label Oct 23, 2025
@Lennonka Lennonka added the Waiting on contributor Requires an action from the author label Oct 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Needs style review Requires a review from docs style/grammar perspective Needs tech review Requires a review from the technical perspective Waiting on contributor Requires an action from the author

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants