-
Notifications
You must be signed in to change notification settings - Fork 105
Distinguish between HTTP booting stages #4304
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
some suggestions on style/conventions.
guides/common/modules/con_uefi-http-booting-requirements-with-managed-dhcp.adoc
Outdated
Show resolved
Hide resolved
guides/common/modules/proc_configuring-smart-proxy-for-http-booting.adoc
Outdated
Show resolved
Hide resolved
32f53e6 to
e6b0e6e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
one minor suggestion. Overall, LGTM style-wise.
e6b0e6e to
c7eeabe
Compare
|
@stejskalleos Can you please review this? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tech ACK
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
style-wise LGTM
|
@jloeser Please rebase your branch to HEAD of "master" and resolve the merge conflicts. |
c7eeabe to
97f98f7
Compare
|
I rebuilt/tested documentation locally and it LGTM. |
|
Looks like we need some technical adaptions regarding HTTPS - it simply does not work at all with GRUB2. I will take care ... |
During network based provisioning, there are two stages where either TFTP or HTTP(S) can be used: fetching the boot loader and fetching installation files such as Linux kernel and initrd. Both were partly mixed, partly incomplete, and instructions were ambiguous or did not work.
97f98f7 to
325cc8c
Compare
|
Related: theforeman/foreman#10718 |
During network based provisioning, there are two stages where either TFTP or HTTP(S) can be used: fetching the boot loader and fetching installation files such as Linux kernel and initrd.
Both were partly mixed, partly incomplete, and instructions were ambiguous or did not work.
What changes are you introducing?
Why are you introducing these changes? (Explanation, links to references, issues, etc.)
Anything else to add? (Considerations, potential downsides, alternative solutions you have explored, etc.)
Contributor checklists
Please cherry-pick my commits into: