Skip to content

refactor (.NET) : Simplify-dotnet-projects #6803

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 11 commits into
base: master
Choose a base branch
from
Open

refactor (.NET) : Simplify-dotnet-projects #6803

Show file tree
Hide file tree
Changes from 7 commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
072d937
Update config.yaml
ShreyasJejurkar Aug 8, 2023
dc8cf63
Merge pull request #3 from ShreyasJejurkar/ShreyasJejurkar-patch-1-2
ShreyasJejurkar Aug 8, 2023
ba69070
Merge branch 'the-benchmarker:master' into master
ShreyasJejurkar Aug 9, 2023
e8e71c9
Merge branch 'the-benchmarker:master' into master
ShreyasJejurkar Oct 8, 2023
ef9833c
Merge branch 'the-benchmarker:master' into master
ShreyasJejurkar Oct 8, 2023
75266ff
refactor (dotnet) : Simplify project setup
ShreyasJejurkar Oct 8, 2023
4e0a522
update docker file to include props
ShreyasJejurkar Oct 8, 2023
8dc0710
update oince again
ShreyasJejurkar Oct 8, 2023
176a8c4
correct the path
ShreyasJejurkar Oct 8, 2023
4cf8952
troubleshooting
ShreyasJejurkar Oct 8, 2023
6eeb22c
trying again
ShreyasJejurkar Oct 8, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions csharp/Directory.Build.props
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
<Project>
<PropertyGroup>
<TargetFramework>net7.0</TargetFramework>
<ImplicitUsings>enable</ImplicitUsings>
</PropertyGroup>
</Project>
1 change: 1 addition & 0 deletions csharp/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ WORKDIR /usr/src/app

# copy csproj and restore as distinct layers
COPY *.csproj .
COPY Directory.Build.props .
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure it will work, docker root directoy is csharp/carter not csharp

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why its set to csharp/carter? hmm, how do I achieve this now?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did ../Directory.build.props but still does not work. any idea?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the easyiest way to do the trick @ShreyasJejurkar is, imho, to use symlinks (create main file is csharp, and create symlinks in all frameworks directory)

RUN dotnet restore

# copy everything else and build app
Expand Down
4 changes: 0 additions & 4 deletions csharp/aspnet-minimal-api/web.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,2 @@
<Project Sdk="Microsoft.NET.Sdk.Web">
<PropertyGroup>
<TargetFramework>net7.0</TargetFramework>
<ImplicitUsings>enable</ImplicitUsings>
</PropertyGroup>
</Project>
4 changes: 0 additions & 4 deletions csharp/simplify.web/web.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,4 @@
<Project Sdk="Microsoft.NET.Sdk.Web">
<PropertyGroup>
<TargetFramework>net7.0</TargetFramework>
<ImplicitUsings>enable</ImplicitUsings>
</PropertyGroup>
<ItemGroup>
<PackageReference Include="Simplify.Web" Version="4.7.*" />
</ItemGroup>
Expand Down