compact: Add resolution information to compaction and downsample logs

[Naman-B-Parlecha]

• I added CHANGELOG entry for this change.
• Change is not relevant to the end user.

Changes

Checks #8350

Adding resolution level (raw, 5m, 1h) to compact and downsample log messages to have more context

Verification

[Naman-B-Parlecha]

@MichaHoffmann @GiedriusS
Currently the ResolutionToString function is not following DRY, as i couldnt find the correct place to add it.

Any specific file that i m missing to add it?

[julienlau]

It will be very helpful, thanks.
It's not exaclty in the scope of this PR given the title, but I think it would have been nice to have both : resolution and compact level in order to have the same information as in the bucket web UI.
-> meta.Compaction.Level

In addition I think it would be nice to have a log at debug level in https://github.com/thanos-io/thanos/blob/main/pkg/compact/downsample/downsample.go
to says that "Downsampling at resolution {} on time window {} is on going" for example.

[Naman-B-Parlecha]

@julienlau refactoring

[Naman-B-Parlecha]

@yeya24

Rather than having to add resolution on all logs, would it be good if

thanos/pkg/compact/compact.go

Line 368 in ddd5ff8

log.With(g.logger, "group", fmt.Sprintf("%s@%v", resolutionLabel, lbls.String()), "groupKey", groupKey),

is refactored to having resolution = raw resolution = 5m resolution = 1hr or having it seperated in each log needed??

[yeya24]

@Naman-B-Parlecha We can have it just in the logger. I would just use 0s, 5m and 1h as resolution value, which is the standard duration string in Go.

[Naman-B-Parlecha]

Yes works

[yeya24]

Thanks. Just small nits

[yeya24]

Why do we change the existing group field? If we want to be explicit I would add another logger field for resolution

[Naman-B-Parlecha]

i was thinking if '0' stands for the resolution anyways in logs, we can just have it logs in better way?

[Naman-B-Parlecha]

I have added a new field called resolution
but ya having this setup would be better as it already exists

[Naman-B-Parlecha]

@yeya24 PTAL added Compact Level on @julienlau 's request.
I m not sure if that is something that we want or not

[Naman-B-Parlecha]

@yeya24 PTAL :D

[Naman-B-Parlecha]

weird ci