docs: update service-discovery docs query flags + alerts metrics #8280
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: trouaux <[email protected]>
Signed-off-by: trouaux <[email protected]>
Signed-off-by: trouaux <[email protected]>
Signed-off-by: trouaux <[email protected]>
Signed-off-by: trouaux <[email protected]>
Signed-off-by: trouaux <[email protected]>
Signed-off-by: trouaux <[email protected]>
|
@MichaHoffmann can you have a second look ? |
|
@GiedriusS can I ask you for a review here |
saswatamcode
reviewed
Jul 4, 2025
| 'lookups {{job}}' | ||
| ) | ||
| ) | ||
| .addPanel( | ||
| g.panel('Errors', 'Shows ratio of failures compared to the total number of executed DNS lookups.') + | ||
| g.qpsErrTotalPanel( | ||
| 'thanos_query_store_apis_dns_failures_total{%s}' % thanos.query.dashboard.selector, | ||
| 'thanos_query_store_apis_dns_lookups_total{%s}' % thanos.query.dashboard.selector, | ||
| 'thanos_query_endpoints_dns_failures_total{%s}' % thanos.query.dashboard.selector, |
There was a problem hiding this comment.
These can be endpoints or endpoint_groups right? Might need to show both in promql
There was a problem hiding this comment.
added alerts and dashboard examples for group dns
| @@ -73,27 +80,27 @@ To use DNS SD, just add one of the following prefixes to the domain name in your | |||
| * `dns+` - the domain name after this prefix will be looked up as an A/AAAA query. *A port is required for this query type*. An example using this lookup with a static flag: | |||
|
|
|||
| ``` | |||
| --store=dns+stores.thanos.mycompany.org:9090 | |||
| --endpoint.sd-config=endpoints: [{address: "dns+stores.thanos.mycompany.org:9090"}] | |||
There was a problem hiding this comment.
Hmm maybe this should be quotes.
Also the value doesn't seem like valid YAML to me
There was a problem hiding this comment.
this works in k8s, but indeed needs quote otherwise
spec:
containers:
- args:
- query
- '--endpoint.sd-config=endpoints: [{address: ''prometheus-operated:10901''}]'
Signed-off-by: trouaux <[email protected]>
Signed-off-by: trouaux <[email protected]>
Signed-off-by: trouaux <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes