ruler: Add flag to configure the queue for pending Alertmanager notif… #8234
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roth-wine
force-pushed
the
ruler_alert_capacity_configurable
branch
4 times, most recently
from
8666ef4 to
e64d2eb
Compare
|
Failing test seems unrelated to my changes and might be flacky. |
GiedriusS
reviewed
May 6, 2025
|
Unfortunately, I don't know what a “good” value is or should be. Both the implementation in Thanos and the implementation in Prometheus don't mention anything about this. That's why I would just leave the default and make it configurable as needed. We can also set the flag to hidden if you prefer. |
|
I think let's then make it hidden 👍 |
roth-wine
force-pushed
the
ruler_alert_capacity_configurable
branch
2 times, most recently
from
4f63513 to
ff39a64
Compare
|
I have made the flag hidden 😄 |
roth-wine
force-pushed
the
ruler_alert_capacity_configurable
branch
from
ff39a64 to
b78b796
Compare
|
Failing test seems again unrelated to my changes and might be flacky. |
|
@GiedriusS can this get merged? |
roth-wine
force-pushed
the
ruler_alert_capacity_configurable
branch
from
b78b796 to
fc532f8
Compare
…ications In the [prometheus package](https://github.com/prometheus/prometheus/blob/7789ef 27c838a567edd65b5fb767d4a35cab91ac/cmd/prometheus/main.go#L532) we are already a ble to configure the capacity size. The fixed value could lead to issues sending alerts when evaluating a huge amount of alerts in one ruler instance. Signed-off-by: roth-wine <[email protected]>
roth-wine
force-pushed
the
ruler_alert_capacity_configurable
branch
from
fc532f8 to
f99767d
Compare
|
@GiedriusS i have rebased the branch to get this thing merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Add flag to configure the queue for pending Alertmanager notifications
In the prometheus package we are already able to configure the capacity size. The fixed value could lead to issues sending alerts when evaluating a huge amount of alerts in one ruler instance.