Typing: Allow any iterable types, not just lists in extensions.py
#1439
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, the typing in extensions was using List as the default iterable. In some cases, it might be beneficial to use non-mutable types, which is currently not matching the strict List type. This change uses Iterable type instead so that mutable or non-mutable types alike can be used.
anjaist
force-pushed
the
improve-extensions-typing
branch
from
bd01baa to
375089a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the typing in extensions was using
Listas the default iterable. In some cases, it might be beneficial to use non-mutable types, which is currently not matching the strictListtype.This change uses
Iterabletype instead so that mutable or non-mutable types alike can be used.