Skip to content

Conversation

tasches
Copy link
Collaborator

@tasches tasches commented Aug 15, 2025

Summary by CodeRabbit

  • New Features
    • Added support for a wildcard namespace in Kyverno policy exceptions, enabling cluster-wide applicability.
    • Simplifies configuration by allowing policy exceptions to apply across all namespaces when enabled.

@tasches tasches self-assigned this Aug 15, 2025
Copy link

coderabbitai bot commented Aug 15, 2025

Walkthrough

Added a namespace wildcard to Kyverno policyExceptions in the HelmRelease values by introducing policyExceptions.namespace: '*' while keeping policyExceptions.enabled: true unchanged.

Changes

Cohort / File(s) Summary
Kyverno HelmRelease config
charts/base-cluster/templates/kyverno/kyverno.yaml
Added policyExceptions.namespace: '*' under Kyverno HelmRelease values; no other keys modified.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

I twitch my ears at YAML stars,
Asterisk skies in cluster jars—
Kyverno nods, “Exceptions roam,”
Wildcard paths through namespace foam.
I stamp, I hop—config is bright,
Carrots aligned, releases right.

Tip

🔌 Remote MCP (Model Context Protocol) integration is now available!

Pro plan users can now connect to remote MCP servers from the Integrations page. Connect with popular remote MCPs such as Notion and Linear to add more context to your reviews and chats.

✨ Finishing Touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch feat/kyverno-namespaces

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbitai help to get the list of available commands.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Status, Documentation and Community

  • Visit our Status Page to check the current availability of CodeRabbit.
  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@tasches tasches changed the title feat(base-cluster/kyverno): add capability for exceptions to be in al… base-cluster/kyverno: add capability for exceptions to be in all namespaces Aug 15, 2025
@tasches tasches changed the title base-cluster/kyverno: add capability for exceptions to be in all namespaces feat(base-cluster/kyverno): add capability for exceptions to be in all namespaces Aug 15, 2025
@tasches tasches enabled auto-merge August 15, 2025 09:04
Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
charts/base-cluster/templates/kyverno/kyverno.yaml (1)

61-61: YAML asterisk is safely quoted; keep it that way

Using single quotes prevents YAML alias expansion of *. If you later switch to a templated value, ensure you still apply | quote to avoid unintentional alias parsing or invalid YAML when the value contains special characters.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

💡 Knowledge Base configuration:

  • MCP integration is disabled by default for public repositories
  • Jira integration is disabled by default for public repositories
  • Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 93ae5fc and ef1ede2.

📒 Files selected for processing (1)
  • charts/base-cluster/templates/kyverno/kyverno.yaml (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
  • GitHub Check: check licenses
  • GitHub Check: lint helm chart (base-cluster)
🔇 Additional comments (1)
charts/base-cluster/templates/kyverno/kyverno.yaml (1)

59-62: policyExceptions.namespace="*" — wildcard support confirmed

Confirmed: the Kyverno chart and upstream docs support setting features.policyExceptions.namespace to "*" to accept PolicyExceptions from all namespaces. The repo template already sets this.

Files to note:

  • charts/base-cluster/templates/kyverno/kyverno.yaml — features.policyExceptions.enabled: true and namespace: '*' (around lines 59–61)

Actionable recommendations (advisory):

  • Ensure RBAC prevents untrusted principals from creating PolicyException objects.
  • Optionally make the namespace configurable so deployments can opt out without editing the template.

Suggested optional diff:

-        namespace: '*'
+        namespace: {{ default "*" (index .Values "kyverno" "policyExceptions" "namespace") | quote }}

@tasches tasches added this pull request to the merge queue Aug 15, 2025
Merged via the queue into main with commit 1441fb0 Aug 15, 2025
62 of 70 checks passed
@tasches tasches deleted the feat/kyverno-namespaces branch August 15, 2025 09:36
github-merge-queue bot pushed a commit that referenced this pull request Aug 15, 2025
🤖 I have created a release *beep* *boop*
---


##
[9.3.0](base-cluster-v9.2.0...base-cluster-v9.3.0)
(2025-08-15)


### Features

* **base-cluster/kyverno:** add capability for exceptions to be in all
namespaces
([#1656](#1656))
([1441fb0](1441fb0))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

- New Features
  - Kyverno: enable defining exceptions across all namespaces.
- Documentation
- Added release notes entry for version 9.3.0 describing the Kyverno
capability.
- Chores
  - Bumped base-cluster chart/version to 9.3.0.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->

---------

Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants