-
Notifications
You must be signed in to change notification settings - Fork 11
feat(base-cluster/kyverno): add capability for exceptions to be in all namespaces #1656
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughAdded a namespace wildcard to Kyverno policyExceptions in the HelmRelease values by introducing policyExceptions.namespace: '*' while keeping policyExceptions.enabled: true unchanged. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Poem
Tip 🔌 Remote MCP (Model Context Protocol) integration is now available!Pro plan users can now connect to remote MCP servers from the Integrations page. Connect with popular remote MCPs such as Notion and Linear to add more context to your reviews and chats. ✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
charts/base-cluster/templates/kyverno/kyverno.yaml (1)
61-61
: YAML asterisk is safely quoted; keep it that wayUsing single quotes prevents YAML alias expansion of
*
. If you later switch to a templated value, ensure you still apply| quote
to avoid unintentional alias parsing or invalid YAML when the value contains special characters.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
💡 Knowledge Base configuration:
- MCP integration is disabled by default for public repositories
- Jira integration is disabled by default for public repositories
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (1)
charts/base-cluster/templates/kyverno/kyverno.yaml
(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
- GitHub Check: check licenses
- GitHub Check: lint helm chart (base-cluster)
🔇 Additional comments (1)
charts/base-cluster/templates/kyverno/kyverno.yaml (1)
59-62
: policyExceptions.namespace="*" — wildcard support confirmedConfirmed: the Kyverno chart and upstream docs support setting features.policyExceptions.namespace to "*" to accept PolicyExceptions from all namespaces. The repo template already sets this.
Files to note:
- charts/base-cluster/templates/kyverno/kyverno.yaml — features.policyExceptions.enabled: true and namespace: '*' (around lines 59–61)
Actionable recommendations (advisory):
- Ensure RBAC prevents untrusted principals from creating PolicyException objects.
- Optionally make the namespace configurable so deployments can opt out without editing the template.
Suggested optional diff:
- namespace: '*' + namespace: {{ default "*" (index .Values "kyverno" "policyExceptions" "namespace") | quote }}
🤖 I have created a release *beep* *boop* --- ## [9.3.0](base-cluster-v9.2.0...base-cluster-v9.3.0) (2025-08-15) ### Features * **base-cluster/kyverno:** add capability for exceptions to be in all namespaces ([#1656](#1656)) ([1441fb0](1441fb0)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - New Features - Kyverno: enable defining exceptions across all namespaces. - Documentation - Added release notes entry for version 9.3.0 describing the Kyverno capability. - Chores - Bumped base-cluster chart/version to 9.3.0. <!-- end of auto-generated comment: release notes by coderabbit.ai --> --------- Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
Summary by CodeRabbit