chore(main): [bot] release base-cluster:9.2.0 #1648
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teutonet-bot
requested review from
cwrau,
marvinWolff,
tasches and
a team
as code owners
|
Warning Rate limit exceeded@teutonet-bot has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 25 minutes and 33 seconds before requesting another review. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. 📒 Files selected for processing (2)
WalkthroughThe Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Assessment against linked issues
Possibly related PRs
Suggested reviewers
Poem
✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (3)
.github/release-please/manifest.json(1 hunks)charts/base-cluster/CHANGELOG.md(1 hunks)charts/base-cluster/Chart.yaml(1 hunks)
🧰 Additional context used
🧠 Learnings (6)
📓 Common learnings
Learnt from: cwrau
PR: teutonet/teutonet-helm-charts#1604
File: charts/base-cluster/templates/monitoring/metrics-server/metrics-server.yaml:20-21
Timestamp: 2025-07-24T09:41:28.072Z
Learning: The official kubernetes-sigs/metrics-server Helm chart pins the image tag to a specific version in its values.yaml by default, ensuring reproducible deployments without requiring explicit tag specification in consuming charts.
Learnt from: cwrau
PR: teutonet/teutonet-helm-charts#1601
File: charts/base-cluster/templates/dns/external-dns.yaml:33-39
Timestamp: 2025-07-24T09:56:41.380Z
Learning: In the teutonet-helm-charts base-cluster chart, secret names like "external-dns" for Cloudflare provider are intentionally hard-coded. Users who need custom secret names should use Helm's `valuesFrom` feature to override values rather than expecting dedicated fields in values.yaml. This design keeps the values.yaml clean while still allowing full customization flexibility.
Learnt from: cwrau
PR: teutonet/teutonet-helm-charts#1604
File: charts/base-cluster/templates/monitoring/metrics-server/metrics-server.yaml:20-21
Timestamp: 2025-07-24T09:41:28.072Z
Learning: The kubernetes-sigs/metrics-server Helm chart uses `v{{ .Chart.AppVersion }}` as the default image tag when `image.tag` is empty, which provides pinned versioning through the chart's AppVersion rather than using floating tags like "latest".
Learnt from: cwrau
PR: teutonet/teutonet-helm-charts#1602
File: charts/base-cluster/templates/monitoring/kube-prometheus-stack/oauth-proxy.yaml:38-40
Timestamp: 2025-07-24T09:49:40.961Z
Learning: Official Helm charts like oauth2-proxy manage image versioning automatically through their Chart.yaml appVersion field, making manual tag pinning in consumer values unnecessary and potentially harmful. The chart version itself provides reproducibility by ensuring the correct image tag is used.
📚 Learning: the official kubernetes-sigs/metrics-server helm chart pins the image tag to a specific version in i...
Learnt from: cwrau
PR: teutonet/teutonet-helm-charts#1604
File: charts/base-cluster/templates/monitoring/metrics-server/metrics-server.yaml:20-21
Timestamp: 2025-07-24T09:41:28.072Z
Learning: The official kubernetes-sigs/metrics-server Helm chart pins the image tag to a specific version in its values.yaml by default, ensuring reproducible deployments without requiring explicit tag specification in consuming charts.
Applied to files:
.github/release-please/manifest.jsoncharts/base-cluster/Chart.yaml
📚 Learning: official helm charts like oauth2-proxy manage image versioning automatically through their chart.yam...
Learnt from: cwrau
PR: teutonet/teutonet-helm-charts#1602
File: charts/base-cluster/templates/monitoring/kube-prometheus-stack/oauth-proxy.yaml:38-40
Timestamp: 2025-07-24T09:49:40.961Z
Learning: Official Helm charts like oauth2-proxy manage image versioning automatically through their Chart.yaml appVersion field, making manual tag pinning in consumer values unnecessary and potentially harmful. The chart version itself provides reproducibility by ensuring the correct image tag is used.
Applied to files:
.github/release-please/manifest.jsoncharts/base-cluster/Chart.yaml
📚 Learning: the kubernetes-sigs/metrics-server helm chart uses `v{{ .chart.appversion }}` as the default image t...
Learnt from: cwrau
PR: teutonet/teutonet-helm-charts#1604
File: charts/base-cluster/templates/monitoring/metrics-server/metrics-server.yaml:20-21
Timestamp: 2025-07-24T09:41:28.072Z
Learning: The kubernetes-sigs/metrics-server Helm chart uses `v{{ .Chart.AppVersion }}` as the default image tag when `image.tag` is empty, which provides pinned versioning through the chart's AppVersion rather than using floating tags like "latest".
Applied to files:
.github/release-please/manifest.jsoncharts/base-cluster/Chart.yaml
📚 Learning: in the teutonet-helm-charts base-cluster chart, secret names like "external-dns" for cloudflare prov...
Learnt from: cwrau
PR: teutonet/teutonet-helm-charts#1601
File: charts/base-cluster/templates/dns/external-dns.yaml:33-39
Timestamp: 2025-07-24T09:56:41.380Z
Learning: In the teutonet-helm-charts base-cluster chart, secret names like "external-dns" for Cloudflare provider are intentionally hard-coded. Users who need custom secret names should use Helm's `valuesFrom` feature to override values rather than expecting dedicated fields in values.yaml. This design keeps the values.yaml clean while still allowing full customization flexibility.
Applied to files:
.github/release-please/manifest.jsoncharts/base-cluster/CHANGELOG.mdcharts/base-cluster/Chart.yaml
📚 Learning: in charts/base-cluster/templates/dns/external-dns.yaml, the dns.provider field in values.yaml has al...
Learnt from: cwrau
PR: teutonet/teutonet-helm-charts#1601
File: charts/base-cluster/templates/dns/external-dns.yaml:30-32
Timestamp: 2025-07-24T09:55:53.655Z
Learning: In charts/base-cluster/templates/dns/external-dns.yaml, the dns.provider field in values.yaml has always been expected to be a map format (e.g., `{ cloudflare: {} }`), never a string format. The template correctly uses `{{ .Values.dns.provider | keys | first }}` to extract the provider name from the map keys.
Applied to files:
charts/base-cluster/CHANGELOG.md
🔇 Additional comments (3)
charts/base-cluster/Chart.yaml (2)
18-22: Update thesourcesURL to match the new chart tagLine 19 still references
base-cluster-v9.1.1, but the chart version has been bumped to 9.1.2.
If left unchanged, the link on Artifact Hub and other tooling will point to the previous release tag, which is misleading and may break reproducibility audits.- - https://github.com/teutonet/teutonet-helm-charts/tree/base-cluster-v9.1.1/charts/base-cluster + - https://github.com/teutonet/teutonet-helm-charts/tree/base-cluster-v9.1.2/charts/base-cluster
22-22: Version bump looks goodThe
versionfield correctly increments to 9.1.2 and is consistent with the changelog entry..github/release-please/manifest.json (1)
1-1: Manifest is in syncThe manifest entry for
charts/base-clusternow reflects 9.1.2, keeping Release Please state consistent with the chart metadata.
teutonet-bot
force-pushed
the
release-please--branches--main--components--base-cluster
branch
2 times, most recently
from
24837f9 to
fe31399
Compare
teutonet-bot
changed the title
teutonet-bot
force-pushed
the
release-please--branches--main--components--base-cluster
branch
4 times, most recently
from
167a9b0 to
b0ec607
Compare
teutonet-bot
force-pushed
the
release-please--branches--main--components--base-cluster
branch
from
38624df to
473ed47
Compare
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (3)
charts/base-cluster/CHANGELOG.md (3)
8-10: Use proper capitalization: OCI.Standardize acronym casing for clarity and consistency.
Apply this diff:
-* **base-cluster/cert-manager:** use oci repository ([#1650](https://github.com/teutonet/teutonet-helm-charts/issues/1650)) ([ef6382d](https://github.com/teutonet/teutonet-helm-charts/commit/ef6382dbc078466b98e1fb8a5473839d5b9112a2)) +* **base-cluster/cert-manager:** use OCI repository ([#1650](https://github.com/teutonet/teutonet-helm-charts/issues/1650)) ([ef6382d](https://github.com/teutonet/teutonet-helm-charts/commit/ef6382dbc078466b98e1fb8a5473839d5b9112a2))
17-17: Tighten wording and spacing: “load balancer”, plural “values”.Minor editorial polish for consistency with the PR summary wording.
Apply this diff:
-* **base-cluster/ingress-nginx:** set a couple of timeouts in the loadbalancer to the maximum value ([#1571](https://github.com/teutonet/teutonet-helm-charts/issues/1571)) ([bc6fe78](https://github.com/teutonet/teutonet-helm-charts/commit/bc6fe78413ea26f3b5003d645ef9918d0b346265)) +* **base-cluster/ingress-nginx:** set several load balancer timeouts to their maximum values ([#1571](https://github.com/teutonet/teutonet-helm-charts/issues/1571)) ([bc6fe78](https://github.com/teutonet/teutonet-helm-charts/commit/bc6fe78413ea26f3b5003d645ef9918d0b346265))
15-15: Confirm fix matches linked issue #1644 objectives.The entry mentions baseDomain certificate usage. Please verify the underlying changes:
- Only the wildcard DNS name is included.
- Certificate activation requires both base domain and a DNS provider set.
If helpful, I can scan the chart for the certificate template and values gates to confirm behavior.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
💡 Knowledge Base configuration:
- MCP integration is disabled by default for public repositories
- Jira integration is disabled by default for public repositories
- Linear integration is disabled by default for public repositories
You can enable these settings in your CodeRabbit configuration.
📒 Files selected for processing (3)
.github/release-please/manifest.json(1 hunks)charts/base-cluster/CHANGELOG.md(1 hunks)charts/base-cluster/Chart.yaml(1 hunks)
✅ Files skipped from review due to trivial changes (1)
- charts/base-cluster/Chart.yaml
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
- GitHub Check: check licenses
- GitHub Check: update metadata file for release
- GitHub Check: lint helm chart (base-cluster)
🔇 Additional comments (2)
.github/release-please/manifest.json (1)
1-1: LGTM — base-cluster bumped to 9.2.0; cross-artifact consistency verifiedVerified:
- charts/base-cluster/Chart.yaml — version: 9.2.0 (line 22)
- .github/release-please/manifest.json — "charts/base-cluster":"9.2.0" (line 1)
- charts/base-cluster/CHANGELOG.md — [9.2.0] compare link present (line 3)
No further action required.
charts/base-cluster/CHANGELOG.md (1)
3-3: Compare link and date look correct.Tag range and release date align with the PR summary.
tasches
approved these changes
Aug 15, 2025
teutonet-bot
deleted the
release-please--branches--main--components--base-cluster
branch
|
🤖 Created releases: 🌻 |
This was referenced Aug 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤖 I have created a release beep boop
9.2.0 (2025-08-14)
Features
Bug Fixes
baseDomainis not used (#1644) (6a3ccae)This PR was generated with Release Please. See documentation.
Summary by CodeRabbit
New Features
Bug Fixes
Chores