Skip to content

feat(ci): install gh for self hosted runners #1643

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

tasches
Copy link
Collaborator

@tasches tasches commented Jul 31, 2025

Summary by CodeRabbit

  • Chores
    • Updated workflow to ensure the GitHub CLI is installed before running scripts.
    • Added explicit repository checkout step in the workflow for reliable code access.

@tasches tasches self-assigned this Jul 31, 2025
@tasches tasches requested a review from a team as a code owner July 31, 2025 09:35
@tasches tasches added the ci label Jul 31, 2025
@tasches tasches requested review from SyeKlu and removed request for a team July 31, 2025 09:35
Copy link

coderabbitai bot commented Jul 31, 2025

Walkthrough

The GitHub Actions workflow job was updated to include a step that installs the GitHub CLI (gh) using Homebrew before running the existing environment setup and script. This ensures the gh tool is available for API calls within the job.

Changes

Cohort / File(s) Change Summary
Workflow CLI Installation
.github/workflows/wait-for-checks.yaml
Added a step to install the GitHub CLI (gh) via Homebrew at the start of the workflow job to ensure the CLI tool is available for subsequent commands.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Suggested reviewers

  • SyeKlu

Poem

A hop to Homebrew, a leap to the sky,
Now gh is installed, workflows can fly!
With CLI in paw, checks run with glee,
Automation made easy, as simple as can be.
🐇✨

Note

⚡️ Unit Test Generation is now available in beta!

Learn more here, or try it out under "Finishing Touches" below.


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 62311f4 and 283cf17.

📒 Files selected for processing (1)
  • .github/workflows/wait-for-checks.yaml (1 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • .github/workflows/wait-for-checks.yaml
✨ Finishing Touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch ci/add-bin-for-selfrunners

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai generate unit tests to generate unit tests for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
.github/workflows/wait-for-checks.yaml (1)

20-20: Add a descriptive name and consider using an official setup action for portability

A bare - run: step works, but giving it a name makes the workflow log easier to scan.
Additionally, the hard-coded Homebrew path ties the workflow to a single runner layout. Using the official action (cli/cli-action@v2) or a simple brew install gh keeps the step OS/runner-agnostic and reduces future maintenance.

-      - run: /home/linuxbrew/.linuxbrew/bin/brew install gh
+      - name: Install GitHub CLI
+        # Prefer the official action for better caching & cross-platform support
+        uses: cli/cli-action@v2
+        with:
+          version: stable   # pin if a specific version is required

If you must keep Homebrew, at minimum:

-      - run: /home/linuxbrew/.linuxbrew/bin/brew install gh
+      - name: Install GitHub CLI
+        run: brew install gh
📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between a6ef45a and 1bea4ea.

📒 Files selected for processing (1)
  • .github/workflows/wait-for-checks.yaml (1 hunks)

@@ -17,6 +17,8 @@ jobs:
permissions:
checks: read
steps:
- uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are you checking something out?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was a try to get the brew bin but unfortunately it did not have the desired effect

@tasches tasches marked this pull request as draft August 7, 2025 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants