-
Notifications
You must be signed in to change notification settings - Fork 11
feat(ci): install gh for self hosted runners #1643
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
WalkthroughThe GitHub Actions workflow job was updated to include a step that installs the GitHub CLI ( Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Suggested reviewers
Poem
Note ⚡️ Unit Test Generation is now available in beta!Learn more here, or try it out under "Finishing Touches" below. 📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
.github/workflows/wait-for-checks.yaml (1)
20-20
: Add a descriptivename
and consider using an official setup action for portabilityA bare
- run:
step works, but giving it aname
makes the workflow log easier to scan.
Additionally, the hard-coded Homebrew path ties the workflow to a single runner layout. Using the official action (cli/cli-action@v2
) or a simplebrew install gh
keeps the step OS/runner-agnostic and reduces future maintenance.- - run: /home/linuxbrew/.linuxbrew/bin/brew install gh + - name: Install GitHub CLI + # Prefer the official action for better caching & cross-platform support + uses: cli/cli-action@v2 + with: + version: stable # pin if a specific version is requiredIf you must keep Homebrew, at minimum:
- - run: /home/linuxbrew/.linuxbrew/bin/brew install gh + - name: Install GitHub CLI + run: brew install gh
@@ -17,6 +17,8 @@ jobs: | |||
permissions: | |||
checks: read | |||
steps: | |||
- uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why are you checking something out?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It was a try to get the brew bin but unfortunately it did not have the desired effect
This reverts commit 62311f4.
Summary by CodeRabbit