Rework around running suites in parallel #7
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Added -randomizesuites cli param. Defaults to false ( which means that suites will be run in the same order as specified in XML) 2. Fixed a small bug in ThreadUtil w.r.t triggerAtOnce variable and use of countDownLatch 3. Reworked SuiteRunnerWorker code to ensure that when run in parallel, parent suite is run first and then all child suites are run before reporting the results for parent suite. 4. Fixed the results counts to be handled the same as they were in v5.13.1.
…oolSize == 1 and randomizeSuites == false
Will regenerate these changes without the whitespace and tab related changes
1. Added -randomizesuites cli param. Defaults to false ( which means that suites will be run in the same order as specified in XML) 2. Fixed a small bug in ThreadUtil w.r.t triggerAtOnce variable and use of countDownLatch 3. Reworked SuiteRunnerWorker code to ensure that when run in parallel, parent suite is run first and then all child suites are run before reporting the results for parent suite. 4. Fixed the results counts to be handled the same as they were in v5.13.1.
Changed type of messages back from CharSequence to String to maintain backward compatibility. See http://jira.opensymphony.com/browse/TESTNG-384
Conflicts: src/main/java/org/testng/CommandLineArgs.java src/main/java/org/testng/SuiteRunnerWorker.java src/main/java/org/testng/TestNG.java
1. Using DynamicGraph to store the SuiteRunners based on Suite hierarchy 2. Added GraphThreadPoolExecutor (almost same as GroupThreadPoolExecutor) which takes DynamicGraph and IThreadWorkerFactory. 3. Added IWorker (SuiteRunnerWorker implements IWorker) and IThreadWorkerFactory to use with GraphThreadPoolExecutor 4. Added SuiteWorkerFactory that implements IThreadWorkerFactory. 5. Added new tests to cover more scenarios [This is part 1. Part 2 should be to replace IMethodWorker with IWorker, IWorkerFactory with IThreadWorkerFactory and GroupThreadPoolExecutor woth GraphThreadPoolExecutor] Testing Done: All 483 tests pass.
Remove target, test-output and test-output-tests directories as part of ant clean target.
… 'null' as arguments
krmahadevan
referenced
this pull request
in krmahadevan/testng
Apr 9, 2024
krmahadevan
added a commit
that referenced
this pull request
Apr 9, 2024
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think this time I have it right. The tests are all passing. Please have a look mainly at http://github.com/nullin/testng/commit/f0d2855eea4ce0e0cfc37ec62ae55dcbcfb37724. It has all the information in the description.