ci: prepare the release workflow #107

missedone · 2022-03-06T19:19:55Z

No description provided.

rr-nick-tan · 2022-03-13T18:04:03Z

.github/workflows/ci.yml

+          gpg_private_key: ${{ secrets.gpg_private_key }}
+          gpg_passphrase: ${{ secrets.gpg_passphrase }}
+          nexus_username: ${{ secrets.nexus_username }}
+          nexus_password: ${{ secrets.nexus_password }}


@cbeust could you create the above four secrets at the testng-team github org level?

rr-nick-tan · 2022-03-14T04:14:26Z

fixes #1 , #81

juherr · 2022-03-14T04:48:55Z

@krmahadevan could you try with your credentials?

krmahadevan · 2022-03-14T04:51:34Z

@krmahadevan could you try with your credentials?

@juherr - I didn't get you. What do you want me to try with my credentials ?

juherr · 2022-03-14T06:27:28Z

@krmahadevan add secrets in order to publish artifacts. I think your credentials will work.

krmahadevan · 2022-03-15T06:17:40Z

@juherr - I am searching for my credentials. Not sure where I have saved them after I lost all data on my Hard drive. Please give me sometime on this.

krmahadevan · 2022-04-11T04:27:38Z

@juherr - I managed to finally find the credentials and I have added them to the repo settings

juherr · 2022-04-12T13:17:13Z

@missedone could you check if it is working?

missedone · 2022-04-16T06:22:43Z

@krmahadevan thanks for updating the secrets, however the snapshot publishing failed:
https://github.com/testng-team/testng-remote/runs/6045933404?check_suite_focus=true

could you double check set the gpg secrets with the instruction here https://github.com/samuelmeuli/action-maven-publish#secrets

krmahadevan · 2022-04-22T04:36:49Z

@missedone - I have setup the keys once again, just to rule out any manual errors and it still throws the same error.

I looked at the latest raw logs https://pipelines.actions.githubusercontent.com/serviceHosts/14024220-b483-4fbd-97de-92f0294e671b/_apis/pipelines/1/runs/52/signedlogcontent/2?urlExpires=2022-04-22T04%3A32%3A13.4714860Z&urlSigningMethod=HMACV1&urlSignature=EJWacww9NlYboBLWpI61N6ebEi7fbgtOBhZHTpbPOSM%3D

I see the below lines

2022-04-16T06:16:58.5415754Z   JAVA_HOME: /opt/hostedtoolcache/Java_Adopt_jdk/11.0.11-9/x64
2022-04-16T06:16:58.5416255Z ##[endgroup]
2022-04-16T06:16:58.5785029Z Importing GPG key…
2022-04-16T06:16:58.5864817Z gpg: directory '/home/runner/.gnupg' created
2022-04-16T06:16:58.5868159Z gpg: keybox '/home/runner/.gnupg/pubring.kbx' created
2022-04-16T06:16:58.5884350Z gpg: /home/runner/.gnupg/trustdb.gpg: trustdb created
2022-04-16T06:16:58.5885782Z gpg: key 0F13D5631D6AF36D: public key "Krishnan Mahadevan (***-key) <[email protected]>" imported
2022-04-16T06:16:58.5970714Z gpg: Total number processed: 1
2022-04-16T06:16:58.5971416Z gpg:               imported: 1

Doesn't this mean that the keys were imported?

juherr · 2022-04-27T06:16:45Z

Gpg should be used during the build step in order to sign the jar file.
It could explain the issue.

rr-nick-tan · 2022-04-27T06:30:14Z

@krmahadevan since i don't have the access of the keys for further diagnosing.
could you try with this command being used by the GHA step:

 mvn clean deploy --batch-mode --activate-profiles deploy --settings /home/runner/work/_actions/samuelmeuli/action-maven-publish/v1/settings.xml

NOTE: you have to create a temporary settings.xml with the gpg configured there, remember to use the actual path of settings.xml on your local
Thanks

krmahadevan · 2022-04-27T06:34:24Z

@rr-nick-tan - Can you please let me know if there's a template settings.xml that I can refer to for creating this file locally? I will try this out later today or over the week and post back the results.

rr-nick-tan · 2022-04-27T06:39:04Z

@krmahadevan , right, this is the template https://github.com/samuelmeuli/action-maven-publish/blob/master/settings.xml used by the samuelmeuli/action-maven-publish https://github.com/samuelmeuli/action-maven-publish/blob/master/index.js#L6

.github/workflows/ci.yml

juherr · 2022-05-02T11:36:14Z

Hi,
Any update about this subject? I had a look and everything looks good. I don't understand why it is not working as expected.

krmahadevan · 2022-05-02T11:40:40Z

Hi,

Any update about this subject? I had a look and everything looks good. I don't understand why it is not working as expected.

I haven't been able to get to it. Currently dealing with a health crisis and yet to be discharged from hospital.

In case you have a pair of credentials that can be used can you please try using that @juherr ?

juherr · 2022-05-02T12:10:41Z

@missedone It is working better but it is not yet perfect. I don't understand the auth issue with the last package only.

@krmahadevan Take care of yourself

rr-nick-tan · 2022-05-02T15:48:18Z

@krmahadevan take care

missedone · 2023-05-30T05:55:39Z

@juherr @krmahadevan to unblock the issue, i'm going to use the github package as the maven repository, we can think about the sync to central maven repo later.

to be able to use github package, I have to enable it on the public repo

let me know if you're OK.

missedone · 2023-06-04T23:50:13Z

@krmahadevan @juherr , the gpg signing issue is solved, but now got 401 error when uploading artifacts to OSSRH, is it a different credentials on the maven central repo?

Error: Failed to execute goal org.sonatype.plugins:nexus-staging-maven-plugin:1.6.13:deploy (injected-nexus-deploy) on project testng-remote-test: Failed to deploy artifacts: Could not transfer artifact org.testng.testng-remote:testng-remote6_9_7:jar:javadoc:1.5.0-20230604.233739-1 from/to ossrh (https://s01.oss.sonatype.org/content/repositories/snapshots): Transfer failed for https://s01.oss.sonatype.org/content/repositories/snapshots/org/testng/testng-remote/testng-remote6_9_7/1.5.0-SNAPSHOT/testng-remote6_9_7-1.5.0-20230604.233739-1-javadoc.jar 401 Unauthorized -> [Help 1]

https://github.com/testng-team/testng-remote/actions/runs/5171772022/jobs/9315501084

I'm following the publishing procedure per the articles:

krmahadevan · 2023-06-05T02:43:16Z

@missedone - I haven't changed anything on the Nexus credentials

I think its still referring to @cbeust credentials (since we are still publishing to org.testng space which is owned by cedric).

Do you remember what user id we were using to publish testng remote ?

missedone · 2023-06-05T02:48:26Z

@krmahadevan i have no idea whose user ID is used. If you have nexus credentials, could you enter your nexus user name and password in this repo’s secrets ?

krmahadevan · 2023-06-05T02:53:30Z

@missedone - I have added my credentials as seen below

But I am not sure if they work in this case, because I think the credentials are tied to the group id into which publishing is being done.
My credentials can publish into com.rationaleemotions but we are trying to publish into org.testng.

missedone · 2023-06-05T03:02:18Z

right, the credentials tie to the group ID

BTW, I noticed the group id org.testng is not available on the s01.oss snapshot repo, it might be the issue.
https://s01.oss.sonatype.org/content/repositories/snapshots/org/testng

krmahadevan · 2023-06-05T03:11:54Z

I am not sure what would be the url for the snapshot repo. But I tried oss.sonatype url and it says directory browsing disabled

But the search UI on sonatype shows that the snapshot group id for testng is available

pom.xml

missedone · 2023-06-05T04:47:50Z

oh man, you saved my day, the trick worked

missedone · 2023-06-05T04:56:23Z

@krmahadevan @juherr , pls review the PR

i'm going to create a separate PR for the release job

krmahadevan · 2023-06-05T04:57:09Z

@missedone - I will go ahead and delete those credential keys that I added to this repo, so that we dont cause any additional confusions ?

missedone force-pushed the ci/publish branch from 7e8dad8 to 5f74fe2 Compare March 13, 2022 17:53

ci: prepare the release workflow

a5cb78d

missedone force-pushed the ci/publish branch 2 times, most recently from a66de1a to 3b378e4 Compare March 13, 2022 17:58

ci: publish snapshots to ossrh

869a8bd

missedone force-pushed the ci/publish branch from 3b378e4 to 869a8bd Compare March 13, 2022 18:02

rr-nick-tan reviewed Mar 13, 2022

View reviewed changes

rr-nick-tan added 2 commits April 15, 2022 17:30

ci: use the new secrets

5665f9d

test publishing snapshot

0bd299d

juherr reviewed May 2, 2022

View reviewed changes

.github/workflows/ci.yml Outdated Show resolved Hide resolved

ci: publish on java 8 only

3fc574c

missedone mentioned this pull request May 30, 2023

ci: add maven wrapper to pin the maven version testng-team/testng-eclipse#552

Merged

missedone added 2 commits June 3, 2023 22:57

Merge branch 'master' into ci/publish

3abcf15

ci: publish snapshots to ossrh

452283b

missedone force-pushed the ci/publish branch from c44f582 to 452283b Compare June 4, 2023 06:15

missedone added 4 commits June 3, 2023 23:24

Merge branch 'master' into ci/publish

322dfa6

ci: publish snapshots to ossrh

5dc545c

ci: temporarily disable build and test

19984c5

ci: ignore javadoc warning

d0f2d56

krmahadevan reviewed Jun 5, 2023

View reviewed changes

pom.xml Outdated Show resolved Hide resolved

ci: use https://oss.sonatype.org

34d4f70

ci: use https://oss.sonatype.org

dcbf43d

missedone marked this pull request as ready for review June 5, 2023 04:55

missedone requested a review from a team as a code owner June 5, 2023 04:55

krmahadevan approved these changes Jun 5, 2023

View reviewed changes

juherr approved these changes Jun 5, 2023

View reviewed changes

missedone added 3 commits June 4, 2023 22:55

ci: fix groovy grape failed to download osgi jars

5bb5dfa

Merge branch 'master' into ci/publish

5e4db5d

ci: fix groovy grape failed to download osgi jars

1cd3fee

missedone force-pushed the ci/publish branch from d0bd5cf to 1cd3fee Compare June 5, 2023 06:21

ci: fix groovy grape failed to download osgi jars

091bc70

missedone merged commit 30cc5a6 into master Jun 5, 2023

missedone deleted the ci/publish branch June 5, 2023 06:41

ci: prepare the release workflow #107

ci: prepare the release workflow #107

Uh oh!

Conversation

missedone commented Mar 6, 2022

Uh oh!

rr-nick-tan Mar 13, 2022

Choose a reason for hiding this comment

Uh oh!

rr-nick-tan commented Mar 14, 2022

Uh oh!

juherr commented Mar 14, 2022

Uh oh!

krmahadevan commented Mar 14, 2022

Uh oh!

juherr commented Mar 14, 2022

Uh oh!

krmahadevan commented Mar 15, 2022

Uh oh!

krmahadevan commented Apr 11, 2022

Uh oh!

juherr commented Apr 12, 2022

Uh oh!

missedone commented Apr 16, 2022

Uh oh!

krmahadevan commented Apr 22, 2022

Uh oh!

juherr commented Apr 27, 2022

Uh oh!

rr-nick-tan commented Apr 27, 2022

Uh oh!

krmahadevan commented Apr 27, 2022

Uh oh!

rr-nick-tan commented Apr 27, 2022

Uh oh!

Uh oh!

juherr commented May 2, 2022

Uh oh!

krmahadevan commented May 2, 2022

Uh oh!

juherr commented May 2, 2022

Uh oh!

rr-nick-tan commented May 2, 2022

Uh oh!

missedone commented May 30, 2023

Uh oh!

missedone commented Jun 4, 2023

Uh oh!

krmahadevan commented Jun 5, 2023

Uh oh!

missedone commented Jun 5, 2023

Uh oh!

krmahadevan commented Jun 5, 2023

Uh oh!

missedone commented Jun 5, 2023

Uh oh!

krmahadevan commented Jun 5, 2023

Uh oh!

Uh oh!

missedone commented Jun 5, 2023

Uh oh!

missedone commented Jun 5, 2023

Uh oh!

krmahadevan commented Jun 5, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants