Skip to content

Conversation

@fokion
Copy link
Contributor

@fokion fokion commented Jan 21, 2025

In the #9222 a user is specifying a property with the field name compose.container.image and the ComposeContainer when it creates the composeDelegate variable is always picking the 24.0.2 version of docker. The change that I am proposing is to use the TestcontainersConfiguration in order to parse the property compose.container.image if it exists otherwise continue as it was in the past. Updated the constructors based on the feedback.

@fokion fokion requested a review from a team January 21, 2025 22:22
@fokion fokion force-pushed the feat/update-compose-container branch from 3ae5baa to 10d6485 Compare January 23, 2025 09:06
Copy link
Member

@eddumelendez eddumelendez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution. I've left some comments. Also adding proper docs and tests would be nice.

@fokion fokion force-pushed the feat/update-compose-container branch from 45b2894 to 2dd3b3d Compare February 6, 2025 23:46
@fokion fokion force-pushed the feat/update-compose-container branch from 1e80f8d to 6c23e41 Compare February 17, 2025 23:45
@viktorgt
Copy link

viktorgt commented Apr 1, 2025

Is there any chance this could be fixed soon? It's a simple change, but it has a significant impact — currently, it's blocking our use of the Compose Module in CI.

I've incorporated the review comments in this update; hopefully, this helps move things forward for a quick release.
https://github.com/viktorgt/testcontainers-java/tree/feat/update-compose-container

@fokion fokion force-pushed the feat/update-compose-container branch from 6c23e41 to 2660009 Compare April 6, 2025 12:53
@fokion
Copy link
Contributor Author

fokion commented Apr 7, 2025

I have updated it with some tests it is failing on a random test on toxiproxy which should not be affected ( maybe it can be rerun ) .Can you have a look again @eddumelendez

@viktorgt
Copy link

Any news on this?

@chinwobble
Copy link

chinwobble commented Jun 6, 2025

Hi our team is also looking to use this feature.
Any chance this can be merged?
@eddumelendez

@fokion
Copy link
Contributor Author

fokion commented Jun 14, 2025

Hi @eddumelendez can you review this and maybe merge it :) ?

@omnibrain
Copy link

This is also blocking my company to use Testcontainers, would be amazing if this could be merged

@fokion fokion force-pushed the feat/update-compose-container branch from 13f1052 to 5442e1b Compare July 26, 2025 16:47
@eddumelendez eddumelendez requested a review from a team as a code owner August 18, 2025 16:56
@fokion
Copy link
Contributor Author

fokion commented Sep 3, 2025

still no review from the team ?

@eddumelendez eddumelendez force-pushed the feat/update-compose-container branch from aaf378b to 9df92b2 Compare October 10, 2025 02:20
@eddumelendez eddumelendez added the type/breaking-api-change Public APIs are being changed label Oct 10, 2025
@eddumelendez eddumelendez added this to the next milestone Oct 10, 2025
@eddumelendez eddumelendez force-pushed the feat/update-compose-container branch 2 times, most recently from c60d8a3 to 14be0bb Compare October 10, 2025 02:32
@eddumelendez eddumelendez force-pushed the feat/update-compose-container branch from 14be0bb to ee13d7d Compare October 10, 2025 03:57
@eddumelendez eddumelendez changed the title Feat/update compose container Add support for specifying Docker image in DockerComposeContainer and ComposeContainer Oct 10, 2025
@eddumelendez eddumelendez merged commit 9cbe138 into testcontainers:main Oct 10, 2025
101 checks passed
@eddumelendez
Copy link
Member

Thanks for your contribution!

@fokion fokion deleted the feat/update-compose-container branch October 10, 2025 09:13
*
* @return this instance, for chaining
*/
public ComposeContainer withLocalCompose(boolean localCompose) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Without this setter, localCompose is always true and could be inlined.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants