Skip to content

Conversation

@livk-cloud
Copy link
Contributor

About the addition of this PR
#8434
#9465

@livk-cloud livk-cloud requested a review from a team October 26, 2024 07:58
@eddumelendez eddumelendez added this to the next milestone Oct 31, 2024
@eddumelendez
Copy link
Member

good catch, @livk-cloud! However, I am running tests locally and some are failing. Can you please take a look?

@livk-cloud
Copy link
Contributor Author

@eddumelendez You should tell me that there is a problem with those tests so that we can better fix them

@eddumelendez
Copy link
Member

All should be good now. Thanks anyway.

@eddumelendez eddumelendez changed the title fix clickhouse support r2dbc Fix ClickHouse wait strategy Oct 31, 2024
@livk-cloud
Copy link
Contributor Author

That's great, thank you for reviewing and testing , I hope that the next version can be updated, so that it will be more convenient and easy to use when using ClickHouse R2dbc

@eddumelendez eddumelendez merged commit b3ef3d2 into testcontainers:main Oct 31, 2024
105 checks passed
@eddumelendez
Copy link
Member

Thanks for your contribution!

@livk-cloud livk-cloud deleted the fix-clickhouse-r2dbc-bug branch November 15, 2024 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants