Skip to content

Conversation

@rnorth
Copy link
Member

@rnorth rnorth commented Aug 4, 2018

Fixes problem with gzip encoded streams (e.g. copy file from container)

Should close #681

@rnorth rnorth requested a review from bsideup August 4, 2018 15:11
@rnorth rnorth requested a review from kiview as a code owner August 4, 2018 15:11
@rnorth rnorth changed the title Add decompression support to netty exec factory WIP: Add decompression support to netty exec factory Aug 4, 2018
Copy link
Member

@bsideup bsideup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

Fixes problem with gzip encoded streams (e.g. copy file from container)
@rnorth rnorth force-pushed the netty-gzip-handling branch from ce70de9 to 656f190 Compare August 4, 2018 19:19
@rnorth rnorth changed the title WIP: Add decompression support to netty exec factory Add decompression support to netty exec factory Aug 5, 2018
@rnorth
Copy link
Member Author

rnorth commented Aug 5, 2018

Tests are good with Docker for Mac Version 18.06.0-ce-mac70 (26399) and transport.type=netty.

@rnorth rnorth merged commit 9d6d6bb into master Aug 5, 2018
@rnorth rnorth deleted the netty-gzip-handling branch August 5, 2018 06:09
@bsideup bsideup added this to the next milestone Aug 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

copyFileFromContainer returns an empty file if file permissions inside docker container don't have w for owner user

3 participants