Skip to content

Conversation

@sunilarjun
Copy link
Contributor

Hello there! I am a technical writer for Rancher Desktop, and am proposing an update to index.md with environment settings for macOS M1 Rancher Desktop installations that I think would be helpful to testcontainers users. Please let me know if you need any more information, thank you.

@sunilarjun sunilarjun requested a review from a team September 27, 2023 17:44
Copy link
Member

@eddumelendez eddumelendez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much for your contribution, @sunilarjun ! Very glad to see this contribution. I've left one question.

eddumelendez
eddumelendez previously approved these changes Sep 27, 2023
Copy link
Member

@eddumelendez eddumelendez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

kiview
kiview previously approved these changes Sep 28, 2023
Copy link
Member

@kiview kiview left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we also add instructions for Windows?

@eddumelendez eddumelendez dismissed stale reviews from kiview and themself via 4fd71d0 September 28, 2023 14:56
@eddumelendez eddumelendez merged commit 202680e into testcontainers:main Sep 28, 2023
@eddumelendez
Copy link
Member

Thanks for your contribution, @sunilarjun! This section is now live in our docs too. See https://java.testcontainers.org/supported_docker_environment/#rancher-desktop

@sunilarjun
Copy link
Contributor Author

Awesome, thanks so much for the quick addition/review! @eddumelendez

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants