Migrate examples to junit5 #7417
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samed-bicer
force-pushed
the
migrate-examples-junit5
branch
from
0ec2d04 to
7c4ac15
Compare
Contributor
Author
|
hi @eddumelendez, examples are migrated to junit5. Could you please review the PR, thanks! |
Member
eddumelendez
left a comment
eddumelendez
left a comment
There was a problem hiding this comment.
Using JUnit 5, public can be removed from test classes and methods. Please apply this change.
Thanks!
samed-bicer
force-pushed
the
migrate-examples-junit5
branch
from
9847628 to
bad1441
Compare
Contributor
Author
Hi @eddumelendez |
examples/spring-boot-kotlin-redis/src/test/kotlin/com/example/redis/AbstractIntegrationTest.kt
Outdated
Show resolved
Hide resolved
…redis/AbstractIntegrationTest.kt
examples/spring-boot/src/test/java/com/example/AbstractIntegrationTest.java
Outdated
Show resolved
Hide resolved
examples/spring-boot-kotlin-redis/src/test/kotlin/com/example/redis/RedisTest.kt
Outdated
Show resolved
Hide resolved
…redis/RedisTest.kt
examples/spring-boot-kotlin-redis/src/test/kotlin/com/example/redis/RedisApplicationTests.kt
Outdated
Show resolved
Hide resolved
…redis/RedisApplicationTests.kt
eddumelendez
approved these changes
Aug 30, 2023
Member
|
Thanks for your contribution @samed-bicer ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
migrate examples from junit4 to junit5
#6921