Update CassandraContainer comment to reflect compaitiblity with 4.x #7013
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Can we add a proper test to make sure it works, please? |
add test against cassandra 4 update comment to reflect cassandra 4.x compatibility fixes testcontainers#7012
Contributor
Author
yep, I was actually already working on that before you commented :) I just pushed an update |
eddumelendez
reviewed
May 5, 2023
modules/cassandra/src/test/java/org/testcontainers/containers/CassandraServer4Test.java
Outdated
Show resolved
Hide resolved
…CassandraServer4Test.java
eddumelendez
reviewed
May 5, 2023
modules/cassandra/src/main/java/org/testcontainers/containers/CassandraContainer.java
Outdated
Show resolved
Hide resolved
…CassandraContainer.java
eddumelendez
reviewed
May 6, 2023
modules/cassandra/src/main/java/org/testcontainers/containers/CassandraContainer.java
Outdated
Show resolved
Hide resolved
…CassandraContainer.java
eddumelendez
approved these changes
May 6, 2023
Contributor
Author
|
Thanks for the fixups! |
Member
|
Thank you for your contribution, @wakingrufus ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
update comment to reflect cassandra 4.x compatibility fixes #7012