Remove unnecessary configuration from simple tests #5973
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
JanHendrikDolling
commented
Oct 4, 2022
JanHendrikDolling
commented
- remove mysql configuration from simple test
- mysql custom ini file test also runs on Windows
- remove mysql configuration from simple test
kiview
approved these changes
Oct 4, 2022
Member
kiview
left a comment
kiview
left a comment
There was a problem hiding this comment.
Thanks, indeed the test nowadays runs completely fine on Windows, there has to be some historic reason why it used to be disabled (back in 2016).
Removing the withConfigurationOverride from testSimple is appropriate, since this is tested explicitly in testMySQLWithCustomIniFile.
eddumelendez
changed the title
kiview
requested changes
Oct 4, 2022
modules/mysql/src/test/java/org/testcontainers/junit/mysql/SimpleMySQLTest.java
Outdated
Show resolved
Hide resolved
…pleMySQLTest.java Co-authored-by: Kevin Wittek <[email protected]>
kiview
approved these changes
Oct 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.