Run mongosh or mongo if cmd exists #5774
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, the command execution relied on the image version which is different when building custom images. Instead, `mongosh` or `mongo` is executed if it is present within the PATH.
kiview
approved these changes
Aug 29, 2022
In order to make sure tests are performing operations test has been updated.
melix
added a commit
to micronaut-projects/micronaut-test-resources
that referenced
this pull request
Aug 30, 2022
This works around a breaking change in the latest image which isn't compatible with Testcontainers. See testcontainers/testcontainers-java#5774
melix
added a commit
to micronaut-projects/micronaut-test-resources
that referenced
this pull request
Aug 30, 2022
* Let the user choose a custom db name Fixes #74 * Hardcode MongoDB image version This works around a breaking change in the latest image which isn't compatible with Testcontainers. See testcontainers/testcontainers-java#5774
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the command execution relied on the image version which
is different when building custom images. Instead,
mongoshormongois executed if it is present within the PATH.