Made k3s documentation a little clearer about starting the container #5175
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… and added info about a know issue with EC keys
kiview
previously approved these changes
Mar 18, 2022
Member
kiview
left a comment
kiview
left a comment
There was a problem hiding this comment.
Thanks for the contribution @georgecodes, I think this is indeed a helpful hint for many users.
modules/k3s/src/test/java/org/testcontainers/k3s/Fabric8K3sContainerTest.java
Outdated
Show resolved
Hide resolved
eddumelendez
requested changes
Jun 26, 2023
modules/k3s/src/test/java/org/testcontainers/k3s/Fabric8K3sContainerTest.java
Outdated
Show resolved
Hide resolved
modules/k3s/src/test/java/org/testcontainers/k3s/Fabric8K3sContainerTest.java
Outdated
Show resolved
Hide resolved
eddumelendez
approved these changes
Jun 26, 2023
Member
|
Thanks for your contribution, @georgecodes ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I also encountered an issue with the Fabric8 client - have not tried with the official client but I imagine the issue remains - regarding the k3s cluster issuing elliptic curve keys.