Reinstate usage of READ_ONLY_REMOTE_GRADLE_CACHE to avoid wrong cache hits
#4853
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rnorth
approved these changes
Jan 5, 2022
Member
rnorth
left a comment
rnorth
left a comment
There was a problem hiding this comment.
This seems reasonable to me, but as you suggested separately I'd agree that this testMatrix approach deserves a revisit to see if it's truly scaling well for us.
rnorth
approved these changes
Jan 5, 2022
bsideup
approved these changes
Jan 5, 2022
kiview
changed the title
testMatrix task to avoid wrong cache hitsREAD_ONLY_REMOTE_GRADLE_CACHE to avoid wrong cache hits
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Through the Dependabot update of Jedis to 4.0.1, we saw that our
testMatrixGradle task falsely populates the cache for the test execution, although the tests are actually not executed.This PR adds an additional input to the test tasks during
testMatrixexecution, so we can ensure that we will end up with a different cache key, as opposed to the actual execution of tests.