Skip to content

Conversation

@rnorth
Copy link
Member

@rnorth rnorth commented Oct 11, 2021

Unblocks #4303

Have tested on #4303's branch; ./gradlew japicmp (across the entire codebase) works as it should.

e.g. for an unpublished module that has no available baseline:

> Task :azure:japicmp SKIPPED
Skipping task ':azure:japicmp' as task onlyIf is false.
:azure:japicmp (Thread[Execution worker for ':' Thread 3,5,main]) completed. Took 0.0 secs.

and for a published module:

> Task :trino:japicmp
Deleting stale output file: /Users/rnorth/github.com/testcontainers/testcontainers-java/modules/trino/build/reports/japi.html
Build cache key for task ':trino:japicmp' is e6e0b417a3a36294106bc367c2fff84f
Task ':trino:japicmp' is not up-to-date because:
  No history is available.
Stored cache entry for task ':trino:japicmp' with cache key e6e0b417a3a36294106bc367c2fff84f
:trino:japicmp (Thread[Execution worker for ':' Thread 3,5,main]) completed. Took 0.252 secs.

@rnorth rnorth requested review from bsideup and kiview as code owners October 11, 2021 11:16
@rnorth rnorth added this to the next milestone Oct 11, 2021
@rnorth rnorth merged commit f31ee79 into master Oct 11, 2021
@rnorth rnorth deleted the japicmp-skip-for-new-modules branch October 11, 2021 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants