Add Thundra Foresight Integration to the CI Build #4313
Conversation
rwxdash
changed the title
rwxdash
force-pushed
the
master
branch
2 times, most recently
from
df249fe to
d39ec9c
Compare
rwxdash
changed the title
| run: | | ||
| ./gradlew --no-daemon --continue --scan ${{matrix.gradle_args}} | ||
| ./gradlew --no-daemon --continue --scan ${{matrix.gradle_args}} \ | ||
| $($THUNDRA_GRADLE_INIT_SCRIPT_PATH || echo "--init-script $THUNDRA_GRADLE_INIT_SCRIPT_PATH") |
There was a problem hiding this comment.
This is the easiest way to understand if the Thundra step was successful and if so, instrument the build. If not, we don't want to break the build. Hence the check.
The template of the init script can be found here: https://github.com/thundra-io/thundra-gradle-test-action/blob/master/templates/thundra.gradle.ejs
| $($THUNDRA_GRADLE_INIT_SCRIPT_PATH || echo "--init-script $THUNDRA_GRADLE_INIT_SCRIPT_PATH") | ||
| env: | ||
| THUNDRA_AGENT_TEST_RUN_ID: ${{ needs.set_thundra_testrun_id.outputs.thundra_agent_testrun_id }} | ||
| THUNDRA_AGENT_REPORT_REST_BASEURL: https://collector.thundra.us/v1 |
There was a problem hiding this comment.
This base URL is for our staging environment. Our showroom page is fetching the data from this environment. Normally, in production, you don't need to set this. We wanted to split the showroom environment from production, that's why this is needed here.
rnorth
left a comment
rnorth
left a comment
There was a problem hiding this comment.
Thanks @rwxdash, and sorry for not reviewing this immediately after getting back from holiday. The extra encapsulation you've done in the thundra_test_initializer really helps a lot - thanks!
Happy to approve, and will merge. Looking forward to seeing the output in Thundra Foresight!
|
Awesome! Thank you, @rnorth. No worries there, we are happy to see you on board. :) |
4 participants
No description provided.