Add support for community edition of couchbase server #4221
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kiview
reviewed
Jul 5, 2021
modules/couchbase/src/test/java/org/testcontainers/couchbase/CouchbaseContainerTest.java
Show resolved
Hide resolved
Member
|
@kiview I guess we can always refactor later, but right now the number of tests is very limited so that little bit of duplication shouldn't be a problem. |
dnault
approved these changes
Jul 13, 2021
kiview
approved these changes
Jul 13, 2021
rnorth
approved these changes
Jul 13, 2021
Member
rnorth
left a comment
rnorth
left a comment
There was a problem hiding this comment.
I think this looks fine to me, thank you @Gerschtli!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up for #4041.