Skip to content

Randomize naming for createVolumeDirectory method #4195

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 23, 2021
Merged

Randomize naming for createVolumeDirectory method #4195

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
aae084b
Randomize naming for createVolumeDirectory method
johnathana Jun 10, 2021
162303d
Mark createVolumeDirectory method as deprecated
johnathana Jun 14, 2021
b4fff57
Merge branch 'master' into fix/tmp-volume-dir
johnathana Aug 14, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion core/src/main/java/org/testcontainers/containers/GenericContainer.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,6 +88,7 @@
import java.util.Objects;
import java.util.Optional;
import java.util.Set;
import java.util.UUID;
import java.util.concurrent.ExecutionException;
import java.util.concurrent.Future;
import java.util.concurrent.TimeUnit;
Expand Down Expand Up @@ -647,8 +648,9 @@ protected Logger logger() {
* @param temporary is the volume directory temporary? If true, the directory will be deleted on JVM shutdown.
* @return path to the volume directory
*/
@Deprecated
protected Path createVolumeDirectory(boolean temporary) {
Path directory = new File(".tmp-volume-" + System.currentTimeMillis()).toPath();
Path directory = new File(".tmp-volume-" + UUID.randomUUID()).toPath();
PathUtils.mkdirp(directory);

if (temporary) Runtime.getRuntime().addShutdownHook(new Thread(DockerClientFactory.TESTCONTAINERS_THREAD_GROUP, () -> {
Expand Down