Skip to content

Conversation

@slovdahl
Copy link
Contributor

@slovdahl slovdahl commented May 4, 2021

No description provided.

@slovdahl slovdahl requested review from bsideup, kiview and rnorth as code owners May 4, 2021 12:30
@slovdahl
Copy link
Contributor Author

slovdahl commented May 4, 2021

Oops, I managed to miss #3683 before submitting this. Feel free to dismiss this one if you think that's the right approach.

@kiview
Copy link
Member

kiview commented May 5, 2021

Thanks for submitting the PR. This looks much more thorough than #3683.
@bsideup should we close the other PR in favor of this one?

@rnorth
Copy link
Member

rnorth commented May 7, 2021

Merging from master to fix build.

@rnorth rnorth changed the title docs: Use testImplementation instead of deprecated testCompile Docs: Use testImplementation instead of deprecated testCompile May 7, 2021
@rnorth rnorth merged commit 99f5fac into testcontainers:master May 7, 2021
@rnorth
Copy link
Member

rnorth commented May 7, 2021

Merged. Thanks @slovdahl!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants