Allow to create a container file from a Transferable (#3814)

[thomasdarimont]

No description provided.

[thomasdarimont]

@bsideup I just rebased this on current master.

[thomasdarimont]

The test-failure seems to come from the API compatibility checks:

Execution failed for task ':testcontainers:japicmp'.
> A failure occurred while executing JApicmp check comparing [testcontainers.jar] with [testcontainers-1.15.2.jar]
   > Detected binary changes between testcontainers.jar and testcontainers-1.15.2.jar. See failure report at file:///home/runner/work/testcontainers-java/testcontainers-java/core/build/reports/japi.html

[thomasdarimont]

@kiview this is the PR :)

[kiview]

The testcontainers:japicmp of course makes sense since this extends the API.
I am not sure if I am a fan of this implicit ordering that is part of the implementation now, WDYT @bsideup @rnorth?

[bsideup]

@kiview need to have a deeper look, but one thing I can say for sure is that public API should not be changed (yay, japicmp! :D)

[kiview]

The failing Netlify jobs originate from the fact, that Netlify tries to build from the branch, rather than from the merged PR (as GHA does). So this branch is still using the old mkdocs version, that pulls in the breaking change from jinja2. Won't be an issue after the merge.

[kiview]

Can we just remove this, to fix japicmp error?

[bsideup]

What does it say?

Default methods should be fine, and, worst case scenario, we could just allowlist it

[kiview]

This is the report:

This is the explanation from Oracle docs on binary compatibility:

Adding a default method, or changing a method from abstract to default, does not break compatibility with pre-existing binaries, but may cause an IncompatibleClassChangeError if a pre-existing binary attempts to invoke the method.

[bsideup]

hmm, of is clearly false positive (isn't a new default method, but static)

updateChecksum can be allow-listed too 👍

[kiview]

This is the other change leading to japicmp error. I am not sure what is the desired pattern to avoid this.

[bsideup]

wait, what? Added static method makes japicmp report it as binary incompatible change? o_O What does it say exactly?

[kiview]

See the other comment, it fails because of METHOD_NEW_DEFAULT rule violation. But I can't say if this is a FP in this case.

[bsideup]

🎉