Search Oracle image name in classpath #3439
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Not sure why the new code looks for the Oracle image name only in the user home directory and not in the config file placed in the classpath. This brakes my test.
bsideup
reviewed
Nov 8, 2020
| @Deprecated | ||
| public String getOracleImage() { | ||
| return getEnvVarOrUserProperty("oracle.container.image", null); | ||
| return getEnvVarOrProperty("oracle.container.image", null); |
Member
There was a problem hiding this comment.
Not for this one... getImage provides a substitute name (or the same name) for a given image.
For Oracle we have no default image name at all, so getImage has nothing to substitute. I don't like this, but it's one of those things with the Oracle module.
As a longer term way to tidy this up, I hope that we can work towards removing 'zero-args' instantiation of Oracle and all other containers: so that both for the constructor in code, and in JDBC URLs, an image name must be specified.
Member
|
@eyalkoren thanks for noticing it! It looks like a leftover from the configuration migration 😅 |
rnorth
approved these changes
Nov 8, 2020
|
If you're coming here looking for a work around in the interim, I found that using the environment variable works just fine. <plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-surefire-plugin</artifactId>
<configuration>
<forkMode>always</forkMode>
<environmentVariables>
<!-- interim workaround for https://github.com/testcontainers/testcontainers-java/pull/3439 -->
<TESTCONTAINERS_ORACLE_CONTAINER_IMAGE>docker/your-non-dcmad-xe-11-image</TESTCONTAINERS_ORACLE_CONTAINER_IMAGE>
</environmentVariables>
</configuration>
</plugin> |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure why the new code looks for the Oracle image name only in the user home directory and ignores the config file placed in the classpath.
Is that intentional?