Allow users to specify a MongoDB database name #2980

silaev · 2020-07-08T07:33:45Z

Related issue #2876

When one uses Testcontainer’s reuse feature, a framework and a database per a test as a way to separate(isolate) data, then specifying a database might be helpful.
For instance, in the Spring Data MongoDB a database name is bound to the MongoTemplate/
ReactiveMongoTemplate and thus it’s a tedious process to change a database name for above-mentioned testing scenario.

Given that, this PR adds ~~a withDatabaseName method for the MongoDBContainer. If the withDatabaseName mothod is not called, then a database name will default to "test" as now.~~ an overloaded getReplicaSetUrl(final String databaseName). The prior getReplicaSetUrl() remains as earlier.

…ners-java

…nfiguration for consistency, Move configure() to be a part of constructors

…ners-java

…, use try-with-resources in test

rnorth · 2020-07-10T13:48:24Z

Should we perhaps have a test for this, to guard against regressions?

…ners-java into issues-2876

silaev · 2020-07-15T11:14:58Z

Should we perhaps have a test for this, to guard against regressions?

Specifying a database name appeals more to frameworks. While working with a Java MongoDB driver directly, we usually call MongoClient#getDatabase() and that's when we specify a database name. Setting a database name in a URL does not lead to a database creation.

However in frameworks, for example in Spring Boot+Spring Data MongoDB, a database name got set to MongoTemplate during auto-configuration from a URL. Then, we don't have to call any getDatabase method at all, a database is created during a first writing call via MongoTemplate/ReactiveMongoTemplate.

Given that I've added a light-weight @DataMongoTest called MongoDBContainerDatabaseNameTest and some additional dependencies in test scope to the build.gradle file of the mongodb module.

bsideup · 2020-07-15T11:58:57Z

@silaev please don't. There is no point in bringing full Spring Boot-based test just to get that getReplicaSetUrl(String) returns correct result. It will only add way more load on CI for nothing.

This reverts commit cc3ed2a

…eTest" This reverts commit 96e9c10

This reverts commit 2086fd6

silaev · 2020-07-15T12:29:44Z

@silaev please don't. There is no point in bringing full Spring Boot-based test just to get that getReplicaSetUrl(String) returns correct result. It will only add way more load on CI for nothing.

Reverted the Spring Boot-based test, added a simple unit test shouldTestDatabaseName.
As I mentioned before, there is no way to assert that this database is created in MongoDB physically (setting a database name in a URL does not lead to a database creation.).

…ners-java into issues-2876

…ners-java

# Conflicts: # modules/mongodb/src/main/java/org/testcontainers/containers/MongoDBContainer.java # modules/mongodb/src/test/java/org/testcontainers/containers/MongoDBContainerTest.java

silaev · 2020-10-11T16:31:30Z

@rnorth @bsideup Could we merge this PR?

rnorth

👍 This looks fine to me.

* Simplify `KafkaContainerCluster#start` * When an image version is not specified, use `latest` as the default tag (#3313) * Add workflow for Update Gradle Wrapper Action. (#3297) Co-authored-by: Richard North <[email protected]> * Always continue on error for examples CI (#3339) * Bump snakeyaml from 1.25 to 1.27 in /core (#3252) Bumps [snakeyaml](https://bitbucket.org/asomov/snakeyaml) from 1.25 to 1.27. - [Commits](https://bitbucket.org/asomov/snakeyaml/branches/compare/snakeyaml-1.27..snakeyaml-1.25) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump lombok from 1.18.12 to 1.18.14 in /examples (#3322) Bumps [lombok](https://github.com/rzwitserloot/lombok) from 1.18.12 to 1.18.14. - [Release notes](https://github.com/rzwitserloot/lombok/releases) - [Changelog](https://github.com/rzwitserloot/lombok/blob/master/doc/changelog.markdown) - [Commits](projectlombok/lombok@v1.18.12...v1.18.14) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump r2dbc-mariadb from 0.8.3-beta1 to 0.8.4-rc in /modules/mariadb (#3300) Bumps [r2dbc-mariadb](https://github.com/mariadb-corporation/mariadb-connector-r2dbc) from 0.8.3-beta1 to 0.8.4-rc. - [Release notes](https://github.com/mariadb-corporation/mariadb-connector-r2dbc/releases) - [Changelog](https://github.com/mariadb-corporation/mariadb-connector-r2dbc/blob/master/CHANGELOG.md) - [Commits](https://github.com/mariadb-corporation/mariadb-connector-r2dbc/commits) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump testng from 7.2.0 to 7.3.0 in /examples (#3068) Bumps [testng](https://github.com/cbeust/testng) from 7.2.0 to 7.3.0. - [Release notes](https://github.com/cbeust/testng/releases) - [Changelog](https://github.com/cbeust/testng/blob/master/CHANGES.txt) - [Commits](https://github.com/cbeust/testng/commits) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump assertj-core from 3.17.1 to 3.17.2 in /core (#3251) Bumps [assertj-core](https://github.com/joel-costigliola/assertj-core) from 3.17.1 to 3.17.2. - [Release notes](https://github.com/joel-costigliola/assertj-core/releases) - [Commits](assertj/assertj@assertj-core-3.17.1...assertj-core-3.17.2) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump aws-java-sdk-dynamodb from 1.11.865 to 1.11.880 in /modules/dynalite (#3332) Bumps [aws-java-sdk-dynamodb](https://github.com/aws/aws-sdk-java) from 1.11.865 to 1.11.880. - [Release notes](https://github.com/aws/aws-sdk-java/releases) - [Changelog](https://github.com/aws/aws-sdk-java/blob/master/CHANGELOG.md) - [Commits](aws/aws-sdk-java@1.11.865...1.11.880) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump mockito-core from 3.5.11 to 3.5.13 in /core (#3275) Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump elasticsearch-rest-client from 7.9.1 to 7.9.2 in /modules/elasticsearch (#3276) Bumps [elasticsearch-rest-client](https://github.com/elastic/elasticsearch) from 7.9.1 to 7.9.2. - [Release notes](https://github.com/elastic/elasticsearch/releases) - [Commits](elastic/elasticsearch@v7.9.1...v7.9.2) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Increase memory limits used in example (#3340) For improved test stability * Bump mockito-core from 3.5.11 to 3.5.13 in /modules/junit-jupiter (#3283) Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Richard North <[email protected]> * Bump tomcat-jdbc from 9.0.37 to 9.0.39 in /modules/jdbc-test (#3338) Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Richard North <[email protected]> * Bump junit from 4.13 to 4.13.1 in /examples (#3328) Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Richard North <[email protected]> * Bump mariadb-java-client from 2.6.2 to 2.7.0 in /modules/mariadb (#3278) Bumps [mariadb-java-client](https://github.com/mariadb-corporation/mariadb-connector-j) from 2.6.2 to 2.7.0. - [Release notes](https://github.com/mariadb-corporation/mariadb-connector-j/releases) - [Changelog](https://github.com/mariadb-corporation/mariadb-connector-j/blob/master/CHANGELOG.md) - [Commits](mariadb-corporation/mariadb-connector-j@2.6.2...2.7.0) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump solr-solrj from 8.6.2 to 8.6.3 in /examples (#3321) Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Richard North <[email protected]> * Bump postgresql from 42.2.16 to 42.2.17 in /examples (#3323) Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Richard North <[email protected]> * Bump postgresql from 42.2.16 to 42.2.17 in /modules/junit-jupiter (#3327) Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Richard North <[email protected]> * Bump postgresql from 42.2.16 to 42.2.17 in /modules/spock (#3330) Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Richard North <[email protected]> * Bump tomcat-jdbc from 9.0.37 to 9.0.39 in /modules/jdbc (#3333) Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Richard North <[email protected]> * Bump postgresql from 42.2.16 to 42.2.17 in /modules/postgresql (#3334) Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Richard North <[email protected]> * Bump aws-java-sdk-sqs from 1.11.860 to 1.11.880 in /modules/localstack (#3337) Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Richard North <[email protected]> * Bump httpclient from 4.5.12 to 4.5.13 in /modules/junit-jupiter (#3326) Bumps httpclient from 4.5.12 to 4.5.13. Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump httpclient from 4.5.12 to 4.5.13 in /modules/spock (#3329) Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Richard North <[email protected]> * Bump cucumber-junit from 6.7.0 to 6.8.1 in /examples (#3325) Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Richard North <[email protected]> * Bump org.springframework.boot from 2.3.3.RELEASE to 2.3.4.RELEASE in /examples (#3247) Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Richard North <[email protected]> * Bump aws-java-sdk-s3 from 1.11.870 to 1.11.880 in /modules/localstack (#3336) Bumps [aws-java-sdk-s3](https://github.com/aws/aws-sdk-java) from 1.11.870 to 1.11.880. - [Release notes](https://github.com/aws/aws-sdk-java/releases) - [Changelog](https://github.com/aws/aws-sdk-java/blob/master/CHANGELOG.md) - [Commits](aws/aws-sdk-java@1.11.870...1.11.880) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump zt-exec from 1.10 to 1.12 in /core (#3253) Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Richard North <[email protected]> * Bump s3 from 2.14.21 to 2.15.7 in /modules/localstack (#3335) Bumps s3 from 2.14.21 to 2.15.7. Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump cucumber-java from 6.6.0 to 6.8.1 in /examples (#3324) Bumps [cucumber-java](https://github.com/cucumber/cucumber-jvm) from 6.6.0 to 6.8.1. - [Release notes](https://github.com/cucumber/cucumber-jvm/releases) - [Changelog](https://github.com/cucumber/cucumber-jvm/blob/main/CHANGELOG.md) - [Commits](cucumber/cucumber-jvm@v6.6.0...v6.8.1) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Remove GitHub Actions cache restore keys (#3342) For more specific cache matching * Allow users to specify a MongoDB database name (#2980) Co-authored-by: Richard North <[email protected]> * Add GCloud module for Google Cloud Datastore, Firestore, PubSub, and Spanner emulators (#2690) Co-authored-by: Richard North <[email protected]> * Use a lighter weight image for MultiplePortsExposedTest (#3343) * Use a lighter weight image for MultiplePortsExposedTest * Update helloworld container version * docker-machine: get full remote daemon URL, to allow for use of custom daemon port (#2769) (#3237) Co-authored-by: Vitalii Chura <[email protected]> * Fix remote gradle cache 400 InvalidArgument error (#3346) per hint given in https://www.digitalocean.com/community/questions/node-upload-file-to-s3-error-invalidargument-null * Add gcloud endpoint accessors (#3344) Co-authored-by: Sergei Egorov <[email protected]> Co-authored-by: Richard North <[email protected]> Co-authored-by: Cristian Greco <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: silaev <[email protected]> Co-authored-by: Eddú Meléndez Gonzales <[email protected]> Co-authored-by: vcvitaly <[email protected]> Co-authored-by: Vitalii Chura <[email protected]>

silaev and others added 30 commits October 7, 2019 16:57

Implement MongoDbContainer

3c07308

change oraclejdk8 with openjdk11, delete obsolete ITTest

a2c5c69

Small fixes

8ddd6b4

Fix docs

1795235

Merge branch 'master' of https://github.com/testcontainers/testcontai…

ee5e4fa

…ners-java

fix mongodb.md

e06749d

Merge branch 'master' of https://github.com/testcontainers/testcontai…

1a2b1dc

…ners-java

Code review remarks adjusted

8f68d71

Merge branch 'master' of https://github.com/testcontainers/testcontai…

58ab3f2

…ners-java

Small fix mongodb.md

957cd51

Small fix mongodb.md

991a5f8

Merge branch 'master' into master

4d9f360

Merge branch 'master' into master

72d2b30

Merge branch 'master' into master

c0fe7ba

Merge branch 'master' of https://github.com/testcontainers/testcontai…

509a454

…ners-java

Merge branch 'master' of https://github.com/testcontainers/testcontai…

d1d0367

…ners-java

Fix container exit code check

184d4e2

Merge branch 'master' of https://github.com/testcontainers/testcontai…

fc45144

…ners-java

Adjust tests and build.gradle to follow Testcontainers module test co…

cfe5177

…nfiguration for consistency, Move configure() to be a part of constructors

Add Javadoc explaining the use of LOCALHOST

a74d766

Refactor to use a default replica set configuration

7620cb8

Merge branch 'master' of https://github.com/testcontainers/testcontai…

4ca7c7b

…ners-java

Remove extra tests

aad0e76

Remove extra unit tests

b92d690

Merge branch 'master' of https://github.com/testcontainers/testcontai…

9a746df

…ners-java

Merge branch 'master' of https://github.com/testcontainers/testcontai…

5c3182e

…ners-java

Remove MockMaker

5f3145b

Merge branch 'master' of https://github.com/testcontainers/testcontai…

2ea01ce

…ners-java

Move initReplicaSet to containerIsStarted, set timeout delay to 100ms…

8b727f0

…, use try-with-resources in test

Make initReplicaSet private

e714b26

silaev requested a review from bsideup July 9, 2020 07:07

silaev added 4 commits July 15, 2020 11:24

Merge branch 'master' of https://github.com/testcontainers/testcontai…

4bef95b

…ners-java into issues-2876

Add MongoDBDatabaseNameTest

2086fd6

Rename MongoDBDatabaseNameTest to MongoDBContainerDatabaseNameTest

96e9c10

Change MongoDBContainerDatabaseNameTest to save a Product

cc3ed2a

silaev added 4 commits July 15, 2020 15:15

Revert "Change MongoDBContainerDatabaseNameTest to save a Product"

4268c93

This reverts commit cc3ed2a

Revert "Rename MongoDBDatabaseNameTest to MongoDBContainerDatabaseNam…

274ce80

…eTest" This reverts commit 96e9c10

Revert "Add MongoDBDatabaseNameTest"

1e41a59

This reverts commit 2086fd6

Add shouldTestDatabaseName unit test

bb0e081

silaev added 5 commits July 28, 2020 13:10

Merge branch 'master' of https://github.com/testcontainers/testcontai…

442d2e5

…ners-java into issues-2876

Use new constructor as per testcontainers#2839

d02daf7

Merge branch 'master' of https://github.com/testcontainers/testcontai…

e67bf4a

…ners-java

Merge branch 'master' of https://github.com/testcontainers/testcontai…

83d6769

…ners-java

Merge branch 'master' into issues-2876

f30c49b

# Conflicts: # modules/mongodb/src/main/java/org/testcontainers/containers/MongoDBContainer.java # modules/mongodb/src/test/java/org/testcontainers/containers/MongoDBContainerTest.java

silaev mentioned this pull request Oct 11, 2020

Allow users to specify a mongo database name #2876

Closed

rnorth approved these changes Oct 11, 2020

View reviewed changes

bsideup approved these changes Oct 12, 2020

View reviewed changes

rnorth added 3 commits October 12, 2020 17:29

Merge branch 'master' into issues-2876

6db6453

Merge branch 'master' into issues-2876

627ddaf

Merge branch 'master' into issues-2876

6a01f5e

rnorth added this to the next milestone Oct 13, 2020

rnorth added the type/feature label Oct 13, 2020

rnorth merged commit 8ab49ee into testcontainers:master Oct 13, 2020

rnorth deleted the issues-2876 branch October 13, 2020 12:36

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

Allow users to specify a MongoDB database name #2980

Allow users to specify a MongoDB database name #2980

Uh oh!

silaev commented Jul 8, 2020 •

edited

Loading

Uh oh!

rnorth commented Jul 10, 2020

Uh oh!

silaev commented Jul 15, 2020

Uh oh!

bsideup commented Jul 15, 2020

Uh oh!

silaev commented Jul 15, 2020 •

edited

Loading

Uh oh!

silaev commented Oct 11, 2020

Uh oh!

rnorth left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Allow users to specify a MongoDB database name #2980

Allow users to specify a MongoDB database name #2980

Uh oh!

Conversation

silaev commented Jul 8, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rnorth commented Jul 10, 2020

Uh oh!

silaev commented Jul 15, 2020

Uh oh!

bsideup commented Jul 15, 2020

Uh oh!

silaev commented Jul 15, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

silaev commented Oct 11, 2020

Uh oh!

rnorth left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

silaev commented Jul 8, 2020 •

edited

Loading

silaev commented Jul 15, 2020 •

edited

Loading