Add ContainerState#getHost replacing getContainerIpAddress
#2742
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # modules/jdbc-test/src/test/java/org/testcontainers/junit/CustomizableMysqlTest.java # modules/jdbc-test/src/test/java/org/testcontainers/junit/CustomizablePostgreSQLTest.java # modules/jdbc-test/src/test/java/org/testcontainers/junit/EmptyPasswordMysqlTest.java # modules/localstack/src/main/java/org/testcontainers/containers/localstack/LocalStackContainer.java # modules/toxiproxy/src/main/java/org/testcontainers/containers/ToxiproxyContainer.java # modules/toxiproxy/src/test/java/org/testcontainers/containers/ToxiproxyTest.java
kiview
approved these changes
May 15, 2020
Member
kiview
left a comment
kiview
left a comment
There was a problem hiding this comment.
I had a suggestion about the Docs/Javadocs, but feel free to ignore this, if I understood it wrongly.
rnorth
reviewed
May 15, 2020
Co-authored-by: Richard North <[email protected]>
rnorth
approved these changes
May 15, 2020
quincy
pushed a commit
to quincy/testcontainers-java
that referenced
this pull request
May 28, 2020
…ontainers#2742) * Add `ContainerState#getHost` replacing `getContainerIpAddress` * post-merge fixes * Ignore `METHOD_NEW_DEFAULT` in japicmp * Update docs/features/networking.md Co-authored-by: Richard North <[email protected]> * Add a tip about `getContainerIpAddress()` * Fix the codeincludes Co-authored-by: Richard North <[email protected]>
mrotteveel
added a commit
to FirebirdSQL/firebird-testcontainers-java
that referenced
this pull request
Aug 2, 2020
sd-yip
added a commit
to sd-yip/testcontainers-java
that referenced
this pull request
May 11, 2021
testcontainers#2742)" This reverts commit 672cbee.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.